Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Jan 2016 09:20:25 +0000 (UTC)
From:      Andrew Rybchenko <arybchik@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r293902 - head/sys/dev/sfxge/common
Message-ID:  <201601140920.u0E9KPPF023206@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: arybchik
Date: Thu Jan 14 09:20:25 2016
New Revision: 293902
URL: https://svnweb.freebsd.org/changeset/base/293902

Log:
  sfxge: cleanup: quieten efx_mcdi_read_resonse_header error reporting
  
  The "mcdi_err_arg" probe still reports results of failed MCDI
  commands, unless the caller invoked efx_mcdi_execute_quiet().
  
  Submitted by:   Andy Moreton <amoreton at solarflare.com>
  Reviewed by:    gnn
  Sponsored by:   Solarflare Communications, Inc.
  MFC after:      2 days
  Differential Revision: https://reviews.freebsd.org/D4919

Modified:
  head/sys/dev/sfxge/common/efx_mcdi.c

Modified: head/sys/dev/sfxge/common/efx_mcdi.c
==============================================================================
--- head/sys/dev/sfxge/common/efx_mcdi.c	Thu Jan 14 09:19:28 2016	(r293901)
+++ head/sys/dev/sfxge/common/efx_mcdi.c	Thu Jan 14 09:20:25 2016	(r293902)
@@ -462,15 +462,8 @@ efx_mcdi_read_response_header(
 	return;
 
 fail3:
-	if (!emrp->emr_quiet)
-		EFSYS_PROBE(fail3);
 fail2:
-	if (!emrp->emr_quiet)
-		EFSYS_PROBE(fail2);
 fail1:
-	if (!emrp->emr_quiet)
-		EFSYS_PROBE1(fail1, efx_rc_t, rc);
-
 	emrp->emr_rc = rc;
 	emrp->emr_out_length_used = 0;
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201601140920.u0E9KPPF023206>