Date: Fri, 12 Apr 2019 16:00:25 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 221297] lang/go: Fix arm build Message-ID: <bug-221297-7788-MgJ4O7MfY7@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-221297-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-221297-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221297 Dmitri Goutnik <dg@syrec.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dg@syrec.org Attachment #203615| |maintainer-approval? Flags| | --- Comment #21 from Dmitri Goutnik <dg@syrec.org> --- Created attachment 203615 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D203615&action= =3Dedit Updated patch for the current lang/go - Set CGO_ENABLED=3D1 unconditionally. CGO_ENABLED already defaults to 1 on= all supported archs except ARM [1], so effectively this change just enables it = on ARM. - Set GOARM from ARCH for ARM archs. The appropriate GOARM value is suppose= d to be chosen automatically when compiling on target hardware but on FreeBSD, i= t is always set to "5" due to the code [2] from a 4 years old commit. I don't kn= ow if "FreeBSD has broken VFP support." is still true, maybe a FreeBSD/ARM exp= ert can chime in on that. QA: Builds fine in poudriere on 12a, 12i and 11a but otherwise untested - lang/= go doesn't currently build in poudriere/qemu on amd64 hosts (comment #14) and qemu-sbruno is marked as BROKEN on i386.=20 [1] https://github.com/golang/go/blob/master/src/cmd/dist/build.go#L1486 [2] https://github.com/golang/go/blob/master/src/cmd/dist/util.go#L400 --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-221297-7788-MgJ4O7MfY7>