Date: Fri, 2 Oct 2020 14:50:03 +0000 (UTC) From: Mateusz Guzik <mjg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r366363 - head/sys/kern Message-ID: <202010021450.092Eo3QS088953@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mjg Date: Fri Oct 2 14:50:03 2020 New Revision: 366363 URL: https://svnweb.freebsd.org/changeset/base/366363 Log: cache: update the commentary for path parsing Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c ============================================================================== --- head/sys/kern/vfs_cache.c Fri Oct 2 14:00:52 2020 (r366362) +++ head/sys/kern/vfs_cache.c Fri Oct 2 14:50:03 2020 (r366363) @@ -3948,10 +3948,10 @@ cache_fplookup_need_climb_mount(struct cache_fpl *fpl) /* * Parse the path. * - * The code is mostly copy-pasted from regular lookup, see lookup(). - * The structure is maintained along with comments for easier maintenance. - * Deduplicating the code will become feasible after fast path lookup - * becomes more feature-complete. + * The code was originally copy-pasted from regular lookup and despite + * clean ups leaves performance on the table. Any modifications here + * must take into account that in case off fallback the resulting + * nameidata state has to be compatible with the original. */ static int cache_fplookup_parse(struct cache_fpl *fpl)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202010021450.092Eo3QS088953>