Date: Tue, 12 Apr 2005 12:23:38 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Matteo Riondato <rionda@gufi.org> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c Message-ID: <200504121223.40429.jhb@FreeBSD.org> In-Reply-To: <20050412153553.GC49623@kaiser.sig11.org> References: <200504120105.j3C15qlZ043565@repoman.freebsd.org> <20050412145806.GA39557@xor.obsecurity.org> <20050412153553.GC49623@kaiser.sig11.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 12 April 2005 11:35 am, Matteo Riondato wrote: > On Tue, Apr 12, 2005 at 07:58:06AM -0700, Kris Kennaway wrote: > > On Tue, Apr 12, 2005 at 04:41:57PM +0200, Alexander Leidinger wrote: > > > John Baldwin <jhb@FreeBSD.org> wrote: > > > > Modified files: > > > > usr.sbin/sysinstall config.c > > > > Log: > > > > Explicitly install linux_base 8 to make sure the right version is > > > > installed. > > > > > > Any ideas how to help sysinstall to get the right one without > > > hardcoding it? Some hints in the linux_base* ports? > > > > > > I have changes in the pipeline which add DEFAULT_LINUX_BASE to > > > bsd.port.mk, it will contain a complete dependency (suitable for e.g. > > > "BUILD_DEPENDS = ${DEFAULT_LINUX_BASE}"), if sysinstall has access to > > > bsd.port.mk it could do "make -f /path/to/bsd.port.mk -V > > > DEFAULT_LINUX_BASE USE_LINUX=yes" and parse the output (when the change > > > is committet). > > > > It doesn't..this will probably just have to be tracked by hand. > > I would say that if all linux ports depend on the same linux_base port, > there wouldn't be more than one linux_base-X package in a -RELEASE CD, > so when during installation, we want to add linux_base, we'll always add > the right one (because there'll be only one in the CD). > The bug appeared on one of the last RELEASEs (see the PR, I seem to > remember that it was 5.3-RELEASE) because there were some ports > (actually _2_) that depended on linux_base-6, so linux_base-6 was > included in the CD and, when the user wanted to add "linux_base", > linux_base-6 was chosen instead of linux_base-7 because "6" comes > before "7". Installs over FTP use the full INDEX that lists all the packages, so they need this regardless of the CD contents. > Please note that the Postfix package depends on a similar hack too (see > usr.sbin/sysinstall/config.c, line 993). Yep. It had it specifically for the FTP case. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200504121223.40429.jhb>