Date: Thu, 23 Sep 2004 16:27:15 -0700 From: Nate Lawson <nate@root.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Joerg Wunsch <joerg@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/fdc fdc.c fdcvar.h Message-ID: <41535BD3.1020609@root.org> In-Reply-To: <200409231923.40285.jhb@FreeBSD.org> References: <200409232112.i8NLCLgQ065917@repoman.freebsd.org> <20040923224739.GE959@green.homeunix.org> <41535A06.7090809@root.org> <200409231923.40285.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
> On Thursday 23 September 2004 07:19 pm, Nate Lawson wrote:
>>Or simpler:
>>
>>foo_kill():
>> error = kthread_suspend(p, kproc_shutdown_wait * hz);
>> if (error == EWOULDBLOCK)
>> printf("timed out\n");
>>
>>foo_thread():
>> for (;;) {
>> mtx_unlock(&bdlock);
>> kthread_suspend_check(bufdaemonproc);
>> ...
>> mtx_lock(&bdlock);
>> if (numdirtybuffers <= lodirtybuffers)
>> msleep(&bd_request, &bdlock, PVM, "psleep", hz);
>
>
> That doesn't actually cause the thread to exit, it just goes to sleep. If fdc
> wants to support detaching and kldunload it needs the thread to actually go
> away, not just go to sleep.
If a thread is suspended and the module is unloaded, what would be the
failure case?
--
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41535BD3.1020609>