Date: Sat, 28 Feb 2015 07:38:12 -0500 From: John Baldwin <jhb@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ian Lepore <ian@freebsd.org> Subject: Re: svn commit: r279338 - head/sys/arm/include Message-ID: <9721184.omIXO1Ld7b@ralph.baldwin.cx> In-Reply-To: <20150228122429.M1198@besplex.bde.org> References: <201502262305.t1QN5lmY075787@svn.freebsd.org> <1425050306.1281.13.camel@freebsd.org> <20150228122429.M1198@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, February 28, 2015 12:38:00 PM Bruce Evans wrote: > On Fri, 27 Feb 2015, Ian Lepore wrote: > > ::sigh:: As usual, thousands of words, maybe there's actionable info in > > > > there, but I sure don't have time to ferret it out. > > > > If there's something simple you'd like me to do, please say so. Simply. > > Just back out the change. For extra credit, back it out for i386 too. > For too much work, fix the 17 calls with bogus casts. Yes. For better or for worse, atomic_*_ptr operate on uintptr_t objects, not void * objects. Bruce explained this to DES before but DES ignored him. If you really want to use explicit atomic ops on void * objects, then the suggestion back then was to add a new 'atomic_*_intptr' or the like and convert all existing uintptr objects (like all the lock cookies) to use those and then change atomic_*_ptr to operate on void * objects. However, that's a fair bit of work. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9721184.omIXO1Ld7b>