Date: Tue, 8 May 2018 22:40:33 +0200 From: Michael Tuexen <tuexen@freebsd.org> To: "N.J. Mann" <njm@njm.me.uk> Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r333382 - head/sys/netinet Message-ID: <4FB5A51E-44A6-476A-9205-F075B85D56F1@freebsd.org> In-Reply-To: <002E38ED710A92624EB727B0@triton.njm.me.uk> References: <201805081848.w48Imq8b082041@repo.freebsd.org> <002E38ED710A92624EB727B0@triton.njm.me.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 8. May 2018, at 21:05, N.J. Mann <njm@njm.me.uk> wrote: >=20 > Hi, >=20 >=20 > On Tuesday, May 08, 2018 18:48:52 +0000 Michael Tuexen = <tuexen@FreeBSD.org> wrote: >> Author: tuexen >> Date: Tue May 8 18:48:51 2018 >> New Revision: 333382 >> URL: https://svnweb.freebsd.org/changeset/base/333382 >>=20 >> Log: >> When reporting ERROR or ABORT chunks, don't use more data >> that is guaranteed to be contigous. > ^^^^^^^^^ > contiguous >=20 > [...] >> Modified: head/sys/netinet/sctputil.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/netinet/sctputil.c Tue May 8 18:25:37 2018 = (r333381) >> +++ head/sys/netinet/sctputil.c Tue May 8 18:48:51 2018 = (r333382) >> @@ -2660,6 +2660,13 @@ sctp_notify_assoc_change(uint16_t state, = struct sctp_t >> notif_len =3D (unsigned int)sizeof(struct = sctp_assoc_change); >> if (abort !=3D NULL) { >> abort_len =3D ntohs(abort->ch.chunk_length); >> + /* >> + * Only SCTP_CHUNK_BUFFER_SIZE are guaranteed to = be >> + * contiguos. > ^^^^^^^^^ > contiguous >=20 > [...] >> @@ -3565,6 +3572,13 @@ sctp_notify_remote_error(struct sctp_tcb = *stcb, uint16 >> } >> if (chunk !=3D NULL) { >> chunk_len =3D ntohs(chunk->ch.chunk_length); >> + /* >> + * Only SCTP_CHUNK_BUFFER_SIZE are guaranteed to be >> + * contiguos. > ^^^^^^^^^ > contiguous >=20 Fixed in https://svnweb.freebsd.org/changeset/base/333386. Thanks for the report. Best regards Michael > Cheers, > Nick. > --=20 >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FB5A51E-44A6-476A-9205-F075B85D56F1>