Date: Fri, 9 Sep 2016 10:40:55 +0000 (UTC) From: Mateusz Guzik <mjg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r305659 - head/sys/fs/nullfs Message-ID: <201609091040.u89Aetgh030438@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mjg Date: Fri Sep 9 10:40:55 2016 New Revision: 305659 URL: https://svnweb.freebsd.org/changeset/base/305659 Log: nullfs: plug vnode ref leak in null_vptocnp The lower vnode is already referenced and nodeget is supposed to consume the reference. Thus the extra vref call was causing a leak. Reported by: pho Reviewed by: kib MFC after: 1 week Modified: head/sys/fs/nullfs/null_vnops.c Modified: head/sys/fs/nullfs/null_vnops.c ============================================================================== --- head/sys/fs/nullfs/null_vnops.c Fri Sep 9 10:04:38 2016 (r305658) +++ head/sys/fs/nullfs/null_vnops.c Fri Sep 9 10:40:55 2016 (r305659) @@ -893,7 +893,6 @@ null_vptocnp(struct vop_vptocnp_args *ap vn_lock(vp, locked | LK_RETRY); return (ENOENT); } - vref(ldvp); error = null_nodeget(vp->v_mount, ldvp, dvp); if (error == 0) { #ifdef DIAGNOSTIC
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201609091040.u89Aetgh030438>