Date: Wed, 22 Jan 1997 21:54:41 -0800 (PST) From: seki@sysrap.cs.fujitsu.co.jp To: freebsd-gnats-submit@freebsd.org Subject: i386/2563: fe driver generates messages without newline Message-ID: <199701230554.VAA29138@freefall.freebsd.org> Resent-Message-ID: <199701230600.WAA29315@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 2563
>Category: i386
>Synopsis: fe driver generates messages without newline
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jan 22 22:00:01 PST 1997
>Last-Modified:
>Originator: Masahiro Sekiguchi
>Organization:
Fujitsu Limited
>Release: 2.2 BETA
>Environment:
>Description:
Fe driver (sys/i386/isa/if_fe.c) has a kind of "typo" in its diagnostic messages. It (possibly) generates messages without newline.
The bug is shared by 2.2 BETA and 3.0 current.
>How-To-Repeat:
The messages are for diagnostics on rare-case error conditions, and it is not easy to see them.
>Fix:
Apply the following patch.
Note that, for 2.2 BETA, this must be applyed *after* applying
the patch on my problem report i386/2421.
--- sys/i386/isa/if_fe.c.old Thu Jan 23 14:29:59 1997
+++ sys/i386/isa/if_fe.c Thu Jan 23 14:34:14 1997
@@ -769,7 +769,7 @@
return 0;
#else
/* Just log the fact and see what happens... FIXME. */
- log( LOG_WARNING, "fe%d: strange I/O config?n", sc->sc_unit );
+ log( LOG_WARNING, "fe%d: strange I/O config?\n", sc->sc_unit );
#endif
}
@@ -857,7 +857,7 @@
} else if ( dev->id_irq != irqmap[ n ] ) {
/* Don't match. */
log( LOG_WARNING,
- "fe%d: check IRQ in config; it may be incorrect",
+ "fe%d: check IRQ in config; it may be incorrect\n",
sc->sc_unit );
}
@@ -2112,7 +2112,7 @@
u_char saved_dlcr5;
#if FE_DEBUG >= 2
- log( LOG_WARNING, "fe%d: emptying receive buffer", sc->sc_unit );
+ log( LOG_WARNING, "fe%d: emptying receive buffer\n", sc->sc_unit );
#endif
/*
* Stop receiving packets, temporarily.
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701230554.VAA29138>