Date: Sat, 20 May 2006 22:15:21 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: jylefort@FreeBSD.org Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/print/acroread7 Makefile pkg-deinstall pkg-plist.7.0.1 pkg-plist.7.0.5 ports/print/acroread7/files pkg-install.in Message-ID: <20060520.221521.122609088.hrs@allbsd.org> In-Reply-To: <20060519090956.4f19dd41.jylefort@FreeBSD.org> References: <20060519075844.e1ac8d3b.jylefort@FreeBSD.org> <20060519.154122.123975929.hrs@allbsd.org> <20060519090956.4f19dd41.jylefort@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Sat_May_20_22_15_21_2006_053)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Jean-Yves Lefort <jylefort@FreeBSD.org> wrote in <20060519090956.4f19dd41.jylefort@FreeBSD.org>: jy> With that interpretation the port is also illegal since it's not only jy> a "new installer", but also "modifies the Software" (through brandelf, jy> for instance): jy> jy> "You may not otherwise alter or modify the Software or create a new jy> installer for the Software." I think neither the port is a new installer nor it modifies the Software, and I think pkg-install script in your patch modifies the installed file. This is my opinion as the port maintainer. jy> Can I fix pkg-deinstall by checking if $PKG_PREFIX/Adobe/Acrobat7.0 is jy> empty after deinstallation? Why do you force me on your idea? I do not like using pkg-install/pkg-deinstall to install the desktop entry in the master port, and I think it should be done by using symlink or so in another port (print/acroreadwrapper or new one), or something like acroreadwrapper's --install-plugin option. We also have to consider mixing of version 7.0.5 and 7.0.1. I can understand installing the desktop entry and the icon file is a good thing (IIRC, netchild@, mezz@, and I discussed this topic before), but at least I have not approved your patch and do not accept the installation/deinstallation scripts you committed. -- | Hiroki SATO ----Security_Multipart(Sat_May_20_22_15_21_2006_053)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBEbxZpTyzT2CeTzy0RAsjcAKCnEPmp14eVfEo6kINTKrmRnxLXyQCgmLNQ 9FHrQnIq7YM7HEuGfEfdzhQ= =5fvP -----END PGP SIGNATURE----- ----Security_Multipart(Sat_May_20_22_15_21_2006_053)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060520.221521.122609088.hrs>