Date: Wed, 25 Feb 2009 14:31:25 -0600 From: Robert Noland <rnoland@FreeBSD.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189052 - head/sys/dev/drm Message-ID: <1235593885.1273.80.camel@widget.2hip.net> In-Reply-To: <20090225194228.GS19161@hoeg.nl> References: <200902251854.n1PIsZZP005285@svn.freebsd.org> <20090225194228.GS19161@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, 2009-02-25 at 20:42 +0100, Ed Schouten wrote:
> Hi Robert,
>
> * Robert Noland <rnoland@FreeBSD.org> wrote:
> > +static struct drm_msi_blacklist_entry drm_msi_blacklist[] = {
> > + {0x8086, 0x2772}, /* Intel i945G */ \
> > + {0x8086, 0x27A2}, /* Intel i945GM */ \
> > + {0x8086, 0x27AE}, /* Intel i945GME */ \
> > + {0, 0}
> > +};
>
> Wouldn't it be better to use PCI_VENDOR_INTEL/PCI_PRODUCT_INTEL_*
> definitions here?
Where are those located? The rest of drm just uses the hex id's, if
there is a better way, I'm up for it.
robert.
--
Robert Noland <rnoland@FreeBSD.org>
FreeBSD
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (FreeBSD)
iEYEABECAAYFAkmlqp0ACgkQM4TrQ4qfROM5vgCfU2jw5FRWMHOeqPmzrwPu7HPS
V/EAn1jC7KGYGKbi6/4Yg/EDrRZw5J0h
=vjqq
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1235593885.1273.80.camel>