Date: Fri, 28 Dec 2018 18:43:39 +0000 From: Chris Rees <crees@FreeBSD.org> To: Niclas Zeising <zeising@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r342389 - head/share/man/man5 Message-ID: <5766D4AE-C093-4B48-9570-E4FC84E63CF2@FreeBSD.org> In-Reply-To: <1c2d5b66-42f2-63e6-9f62-aa383e9b79b9@freebsd.org> References: <201812241047.wBOAlmwc092761@repo.freebsd.org> <1c2d5b66-42f2-63e6-9f62-aa383e9b79b9@freebsd.org>
index | next in thread | previous in thread | raw e-mail
Hey, On 28 December 2018 18:19:57 GMT+00:00, Niclas Zeising <zeising@freebsd.org> wrote: >On 12/24/18 11:47 AM, Chris Rees wrote: >> Author: crees (doc,ports committer) >> Date: Mon Dec 24 10:47:48 2018 >> New Revision: 342389 >> URL: https://svnweb.freebsd.org/changeset/base/342389 >> >> Log: >> Clarify kld_list format >> >> PR: docs/234248 >> Submitted by: David Fiander >> Submitted by: Miroslav Lachman >> >> Modified: >> head/share/man/man5/rc.conf.5 >> >> Modified: head/share/man/man5/rc.conf.5 >> >============================================================================== >> --- head/share/man/man5/rc.conf.5 Mon Dec 24 06:14:32 2018 (r342388) >> +++ head/share/man/man5/rc.conf.5 Mon Dec 24 10:47:48 2018 (r342389) >> @@ -248,12 +248,14 @@ Default >> .Pa /etc/ddb.conf . >> .It Va kld_list >> .Pq Vt str >> -A list of kernel modules to load right after the local >> -disks are mounted. >> +A whitespace-separated list of kernel modules to load right after >> +the local disks are mounted, without any >> +.Pa .ko >> +extension or path. >> Loading modules at this point in the boot process is >> much faster than doing it via >> .Pa /boot/loader.conf >> -for those modules not necessary for mounting local disk. >> +for those modules not necessary for mounting local disks. >> .It Va kldxref_enable >> .Pq Vt bool >> Set to > > >Hi! >Sorry for jumping into this so late. >Please please PLEASE don't break loading modules by path in kld_list. >This is used by the drm-kmod files to distinguish them from the base >modules, and this has been communicated in documentation all over the >place, including numerous ports. > >Can this please be reverted, or amended to match reality. > >In practice, adding both the path and the extension (.ko) to a module >in >kld_list works and the module loads. As the code itself stands, it works for loading, but throws an error if you try to load an already loaded module adding a .ko extension. In other words, it works but is wrong. The path actually still does work, which was my mistake. I'm awaiting approval for this, which correctly handles all cases: https://reviews.freebsd.org/D18670 Konstantin has reviewed, but doesn't feel comfortable giving approval as it's not his area, which is fair enough. Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5766D4AE-C093-4B48-9570-E4FC84E63CF2>