Date: Wed, 21 Nov 2001 11:38:35 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: David Xu <davidx@viasoft.com.cn> Cc: freebsd-hackers@FreeBSD.ORG Subject: RE: add some constraints in cpufunc.h Message-ID: <XFMail.011121113835.jhb@FreeBSD.org> In-Reply-To: <00e701c17264$a4617130$ef01a8c0@davidwnt>
index | next in thread | previous in thread | raw e-mail
On 21-Nov-01 David Xu wrote:
> 4.4-stable, file sys/i386/include/cpufunc.h,
>
> --- cpufunc.h.orig Wed Nov 21 13:35:36 2001
> +++ cpufunc.h Wed Nov 21 15:00:12 2001
> @@ -72,7 +72,7 @@
> {
> u_int result;
>
> - __asm __volatile("bsfl %0,%0" : "=r" (result) : "0" (mask));
> + __asm __volatile("bsfl %0,%0" : "=r" (result) : "0" (mask) : "cc");
> return (result);
> }
>
> @@ -81,7 +81,7 @@
> {
> u_int result;
>
> - __asm __volatile("bsrl %0,%0" : "=r" (result) : "0" (mask));
> + __asm __volatile("bsrl %0,%0" : "=r" (result) : "0" (mask) : "cc");
> return (result);
> }
>
> @@ -305,7 +305,7 @@
> u_int result;
>
> __asm __volatile("xorl %0,%0; xchgl %1,%0"
> - : "=&r" (result) : "m" (*addr));
> + : "=&r" (result) : "m" (*addr) : "cc");
> return (result);
> }
>
Have you had actual bugs as a result of "cc" not being in the constraints?
If so, there's a _lot_ more places that need this. All the atomic ops, for
example.
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011121113835.jhb>