Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Apr 2004 14:45:23 +0200
From:      Oliver Eikemeier <eikemeier@fillmore-labs.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/66110: [PATCH] bsd.port.mk: MLINKS error detection is broken
Message-ID:  <40924A63.9060107@fillmore-labs.com>
Resent-Message-ID: <200404301250.i3UCoL5n010376@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         66110
>Category:       ports
>Synopsis:       [PATCH] bsd.port.mk: inconsistent use of `::' targets
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 30 05:50:20 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Oliver Eikemeier
>Release:        FreeBSD 4.10-STABLE i386
>Organization:
Fillmore Labs - http://www.fillmore-labs.com
>Environment:
System: FreeBSD nuuk.fillmore-labs.com 4.10-STABLE

>Description:

bsd.port.mk sets _TMLINKS to be empty only when _MLINKS is undefined.
This causes errors in generate-plist if a wrong MLINKS definition is
given, rendering the MLINKS check useless

>How-To-Repeat:

cd to any port without MLINKS and do
  make MLINKS=x

>Fix:

(patch from PR 66109 required)

Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.488
diff -u -r1.488 bsd.port.mk
--- bsd.port.mk	19 Apr 2004 23:39:52 -0000	1.488
+++ bsd.port.mk	30 Apr 2004 12:37:35 -0000
@@ -2438,7 +2462,7 @@
 
 .endfor
 
-.if !defined(_MLINKS)
+.if !defined(_TMLINKS)
 _TMLINKS=
 .endif
 

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40924A63.9060107>