Date: Thu, 9 Oct 2003 07:13:55 -0500 From: "Jacques A. Vidrine" <nectar@FreeBSD.org> To: Hiten Pandya <hmp@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libufs bread.3 cgread.3 getino.3 libufs.3 sbread.3 ufs_disk_close.3 Message-ID: <20031009121355.GD94235@madman.celabo.org> In-Reply-To: <200310090945.h999jKns055269@repoman.freebsd.org> References: <200310090945.h999jKns055269@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 09, 2003 at 02:45:20AM -0700, Hiten Pandya wrote:
> hmp 2003/10/09 02:45:20 PDT
>
> FreeBSD src repository (doc committer)
>
> Modified files:
> lib/libufs bread.3 cgread.3 getino.3 libufs.3
> sbread.3 ufs_disk_close.3
> Log:
> Remove unneccessary include of sys/types.h in the SYNOPSIS
> header.
>
> Sys/param.h includes sys/types.h internally unless LOCORE is
> defined.
>
> Approved by: des (mentor)
I think you removed the wrong header. Is <sys/param.h> required in
each of these cases? If not, then I believe the synopsis should refer
only to <sys/types.h>:
(1) Including <sys/types.h> is (by definition) less work than
<sys/param.h>.
(2) <sys/types.h> is a POSIX header, while <sys/param.h> is not.
Cheers,
--
Jacques Vidrine . NTT/Verio SME . FreeBSD UNIX . Heimdal
nectar@celabo.org . jvidrine@verio.net . nectar@freebsd.org . nectar@kth.se
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031009121355.GD94235>