Date: Tue, 2 May 2023 11:25:12 -0800 From: Rob Wing <rob.fx907@gmail.com> To: Matthew Grooms <mgrooms@shrew.net> Cc: freebsd-hackers@freebsd.org, freebsd-virtualization@freebsd.org, elenamihailescu22@gmail.com, Mihai Carabas <mihai.carabas@gmail.com>, gusev.vitaliy@gmail.com Subject: Re: BHYVE_SNAPSHOT Message-ID: <CAF3%2Bn_e3QhbDxk96akwxnjAYkPOcKbLemhdZPmSzbsjB%2BdxfoQ@mail.gmail.com> In-Reply-To: <89c84bd7-a925-02f4-acbe-12c3000e7007@shrew.net> References: <ZEz8tU_83QfqbbMu@int21h> <fe221c6a-acb7-ddbd-413d-7039de33e872@shrew.net> <CAF3%2Bn_fN4J4jXH89t8gMOD8QpqAike0Uzrb9wUfKoYv56zQt_w@mail.gmail.com> <89c84bd7-a925-02f4-acbe-12c3000e7007@shrew.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, May 1, 2023 at 10:16 PM Matthew Grooms <mgrooms@shrew.net> wrote: > Yup. See above. I appreciate your input, but the goal of live migration > was set in 2016 with a prototype first demonstrated in 2018. How long do > you suggest a developer wait without review feedback before moving forward > out of tree? > Yea..I'd say a submitter should receive feedback within a week (or so) and when that passes, try rattling the cage of relevant developers to ack a timeline. My comments for the live/warm migration review is to rebase it after the snapshot feature is compiled in by default. > Yup. That approach was attempted with the Warm Migration patches. From > slide 17 in Elena's presentation: > > First review opened in 2021: https://reviews.freebsd.org/D28270 > 5 reviews from 2022 starting with https://reviews.freebsd.org/D34717 > (same feature split in multiple parts) > I understand that, as a submitter, this is frustrating - to spend a non-trivial amount of time preparing/submitting a review and then receive no feedback, not even a "changes too big" or "nope". For future reference, if UPB does another project - might be worth trying to seek out a FreeBSD mentor that could guide the students and be willing to usher the changes in, not unlike a GSOC project. [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><div dir="ltr">On Mon, May 1, 2023 at 10:16 PM Matthew Grooms <<a href="mailto:mgrooms@shrew.net" target="_blank">mgrooms@shrew.net</a>> wrote:</div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><p>Yup. See above. I appreciate your input, but the goal of live migration was set in 2016 with a prototype first demonstrated in 2018. How long do you suggest a developer wait without review feedback before moving forward out of tree?<br></p></div></blockquote><div><br></div><div>Yea..I'd say a submitter should receive feedback within a week (or so) and when that passes, try rattling the cage of relevant developers to ack a timeline. My comments for the live/warm migration review is to rebase it after the snapshot feature is compiled in by default.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><p> </p> <p>Yup. That approach was attempted with the Warm Migration patches. From slide 17 in Elena's presentation:<br> <br> First review opened in 2021: <a href="https://reviews.freebsd.org/D28270" target="_blank">https://reviews.freebsd.org/D28270</a><br>; 5 reviews from 2022 starting with <a href="https://reviews.freebsd.org/D34717" target="_blank">https://reviews.freebsd.org/D34717</a>; (same feature split in multiple parts)<br></p></div></blockquote><div><br></div><div>I understand that, as a submitter, this is frustrating - to spend a non-trivial amount of time preparing/submitting a review and then receive no feedback, not even a "changes too big" or "nope".</div><div><br></div><div>For future reference, if UPB does another project - might be worth trying to seek out a FreeBSD mentor that could guide the students and be willing to usher the changes in, not unlike a GSOC project.<br></div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF3%2Bn_e3QhbDxk96akwxnjAYkPOcKbLemhdZPmSzbsjB%2BdxfoQ>