Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Sep 2016 17:23:53 +0000 (UTC)
From:      Ed Schouten <ed@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r305938 - head/sys/contrib/cloudabi
Message-ID:  <201609181723.u8IHNr4a020262@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ed
Date: Sun Sep 18 17:23:53 2016
New Revision: 305938
URL: https://svnweb.freebsd.org/changeset/base/305938

Log:
  Fix badly computed register/stack offset of system call output arguments.
  
  Bugs in the Python code used to generate this vDSO caused us to
  miscompute the register numbers/stack offsets at which addresses of the
  system call output arguments were stored.
  
  Together with some other patches, this vDSO allows us to make all of the
  cloudlibc unit tests pass.
  
  Obtained from:	https://github.com/NuxiNL/cloudabi

Modified:
  head/sys/contrib/cloudabi/cloudabi_vdso_armv6.S

Modified: head/sys/contrib/cloudabi/cloudabi_vdso_armv6.S
==============================================================================
--- head/sys/contrib/cloudabi/cloudabi_vdso_armv6.S	Sun Sep 18 16:34:40 2016	(r305937)
+++ head/sys/contrib/cloudabi/cloudabi_vdso_armv6.S	Sun Sep 18 17:23:53 2016	(r305938)
@@ -48,11 +48,10 @@ ENTRY(cloudabi_sys_clock_res_get)
 END(cloudabi_sys_clock_res_get)
 
 ENTRY(cloudabi_sys_clock_time_get)
-  str r3, [sp, #-4]
   mov ip, #1
   swi 0
-  ldr r2, [sp, #-4]
   bcs 1f
+  ldr r2, [sp, #0]
   str r0, [r2, 0]
   str r1, [r2, 4]
   mov r0, $0
@@ -227,7 +226,7 @@ ENTRY(cloudabi_sys_file_open)
   mov ip, #21
   swi 0
   bcs 1f
-  ldr r2, [sp, #12]
+  ldr r2, [sp, #8]
   str r0, [r2]
   mov r0, $0
 1:
@@ -249,7 +248,7 @@ ENTRY(cloudabi_sys_file_readlink)
   mov ip, #23
   swi 0
   bcs 1f
-  ldr r2, [sp, #8]
+  ldr r2, [sp, #4]
   str r0, [r2]
   mov r0, $0
 1:
@@ -367,7 +366,7 @@ ENTRY(cloudabi_sys_poll_fd)
   mov ip, #40
   swi 0
   bcs 1f
-  ldr r2, [sp, #12]
+  ldr r2, [sp, #8]
   str r0, [r2]
   mov r0, $0
 1:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201609181723.u8IHNr4a020262>