Date: Wed, 8 Feb 2012 08:53:47 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: FreeBSD Net <freebsd-net@freebsd.org> Subject: Re: call for review: 802.11q QinQ netgraph support Message-ID: <CAJ-VmokBHkyRC5mAnQkFFL9w-ETwppo_6Ofb8YGa11vEKMcygg@mail.gmail.com> In-Reply-To: <20120208104213.GD13554@FreeBSD.org> References: <CAJ-Vmondr7uO2%2B%2BADk_s=Zpx5HdmABOM=UGP%2BrnGKaNN8zXehQ@mail.gmail.com> <20120208104213.GD13554@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2012/2/8 Gleb Smirnoff <glebius@freebsd.org>:
> A> I would appreciate further review from network/netgraph related
> A> people. I'm going to borrow a term from gnn and say "Silence implies
> A> consent." :-)
>
> I have only minor comments:
Thanks for your feedback!
Ivan, can you please review these?
Adrian
>
> 1.1) According to style(9) new code should use uintXX_t instead of u_intX=
X_t.
> 1.2) Some lines are really loooong, they need to be broken into shorter o=
nes
> =A0 =A0 accoording to style(9).
> 1.3) Operators at beginning of a line - also style(9) violation.
>
> 2) NETGRAPH_DEBUG wasn't designed for the things the patch is doing. But
> =A0 the KASSERT was. So it'll be better to change the code under NETGRAPH=
_DEBUG
> =A0 to KASSERTs. For example in the chunk '@@ -262,35 +322,143 @@':
>
> =A0 =A0 =A0 =A0KASSERT(priv->vlan_hook[EVL_VLANOFTAG(hook_data)] =3D=3D h=
ook,
> =A0 =A0 =A0 =A0 =A0 =A0("%s: NGM_VLAN_DEL_FILTER: Invalid VID for Hook =
=3D %s\n",
> =A0 =A0 =A0 =A0 =A0 =A0__func__, (char *)msg->data));
>
> =A0 =A0 =A0 =A0and
>
> =A0 =A0 =A0 =A0KASSERT(EVL_VLANOFTAG(hook_data) =3D=3D vid,
> =A0 =A0 =A0 =A0 =A0 =A0("%s: NGM_VLAN_DEL_VID_FLT: Invalid VID Hook =3D %=
us, must be: %us\n",
> =A0 =A0 =A0 =A0 =A0 =A0__func__, (uint16_t )EVL_VLANOFTAG(hook_data), vid=
));
>
> --
> Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokBHkyRC5mAnQkFFL9w-ETwppo_6Ofb8YGa11vEKMcygg>