Date: Wed, 8 Jul 2015 16:27:30 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: Pedro Giffuni <pfg@freebsd.org> Cc: Luigi Rizzo <luigi@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285284 - head/lib/liblzma Message-ID: <20150708232729.GX8523@funkthat.com> In-Reply-To: <559D9172.9040305@FreeBSD.org> References: <201507081836.t68IacJu069563@repo.freebsd.org> <559D9172.9040305@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Pedro Giffuni wrote this message on Wed, Jul 08, 2015 at 16:09 -0500: > On 07/08/15 13:36, Luigi Rizzo wrote: > > Author: luigi > > Date: Wed Jul 8 18:36:37 2015 > > New Revision: 285284 > > URL: https://svnweb.freebsd.org/changeset/base/285284 > > > > Log: > > only enable immintrin when clang is used. The base gcc does not support it. > > > > Reviewed by: delphij > > > > Modified: > > head/lib/liblzma/config.h > > > > Modified: head/lib/liblzma/config.h > > ============================================================================== > > --- head/lib/liblzma/config.h Wed Jul 8 18:12:24 2015 (r285283) > > +++ head/lib/liblzma/config.h Wed Jul 8 18:36:37 2015 (r285284) > > @@ -150,7 +150,8 @@ > > #define HAVE_ICONV 1 > > > > /* Define to 1 if you have the <immintrin.h> header file. */ > > -#if defined(__FreeBSD__) && defined(__amd64__) > > +/* FreeBSD - only with clang because the base gcc does not support it */ > > +#if defined(__clang__) && defined(__FreeBSD__) && defined(__amd64__) > > #define HAVE_IMMINTRIN_H 1 > > #endif > > > > > FWIW, gcc 4.3+ does have it so this may some undesired (but hidden) > effect when building with an external gcc. Looking at the header, immintrin.h, it looks like it's just a catch all for various intrinsic headers... And looking at the lzma code, the immintrin.h include could be replaced w/ an emmintrin.h and things would be fine... Though I don't see sse2 being enabled when compiling the library... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150708232729.GX8523>