Date: Fri, 23 Feb 2007 13:37:07 -0700 From: John E Hein <jhein@timing.com> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/ndis kern_ndis.c src/sys/dev/acpica/Osd OsdSchedule.c src/sys/dev/ata ata-all.c atapi-cd.c atapi-tape.c src/sys/dev/ppc ppc.c Message-ID: <17887.20595.540648.699149@gromit.timing.com> In-Reply-To: <200702231625.l1NGP86A029885@repoman.freebsd.org> References: <200702231625.l1NGP86A029885@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote at 16:25 +0000 on Feb 23, 2007: > jhb 2007-02-23 16:25:08 UTC > > FreeBSD src repository > > Modified files: > sys/compat/ndis kern_ndis.c > sys/dev/acpica/Osd OsdSchedule.c > sys/dev/ata ata-all.c atapi-cd.c atapi-tape.c > sys/dev/ppc ppc.c > Log: > Use 'pause' in several places rather than trying to tsleep() on NULL (which > triggers a KASSERT) or local variables. In the case of kern_ndis, the > tsleep() actually used a common sleep address (curproc) making it > susceptible to a premature wakeup. Nice. Maybe you should pass in priority so pause(9) users don't always wake up at PRI_MIN. If not, PZERO might be a more sensible default perhaps. PCATCH complicates this slightly since pause(9) currently returns nothing, but I could see cases where users might want PCATCH.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17887.20595.540648.699149>