Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 06 Aug 2009 14:17:47 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        d@delphij.net
Cc:        freebsd-rc@FreeBSD.org
Subject:   Re: [RFC] script for binding ARP <-> IP pairs
Message-ID:  <4A7B487B.8060303@FreeBSD.org>
In-Reply-To: <4A7B2792.4090803@delphij.net>
References:  <4A7B2792.4090803@delphij.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Xin LI wrote:
> Hi,
> 
> Here is a new rc.d startup script, which helps to bind static ARP
> entries like this:
> 
> 	static_arp_pairs="gw"
> 	arp_gw="172.16.1.254 00:1c:58:6a:7a:4c"
> 
> At the beginning I was inclined to add an "options" part for this script
> which helps to set e.g. logging options for ARP but it looks that these
> would be redundant, i.e., can be done with easy /etc/sysctl.conf.
> 
> Comments?

This looks pretty good. My only suggestion would be to change the file
name, $name and PROVIDE to static_arp (and then in your example above
the second var would be static_arp_gw). I realize that currently we
have a non-trivial number of legacy variables that don't match their
related script names and/or $name, however going forward my preference
would be that we not add any more examples of this. I also think it's
a bit more descriptive of what you're doing in the script.


hth,

Doug



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A7B487B.8060303>