Date: Thu, 19 Jan 2017 23:00:24 -0800 From: Xin Li <delphij@delphij.net> To: Antoine Brodin <antoine@freebsd.org>, Xin LI <delphij@freebsd.org> Cc: d@delphij.net, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312404 - head/usr.bin/sed Message-ID: <9ef03812-a23a-8cd0-d8a1-1568c468e882@delphij.net> In-Reply-To: <CAALwa8neni57SPZAo4jW8wKu-Up0-M=weR31WtndzXdW2_jKmQ@mail.gmail.com> References: <201701190801.v0J81ZG9008267@repo.freebsd.org> <CAALwa8neni57SPZAo4jW8wKu-Up0-M=weR31WtndzXdW2_jKmQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SENJsW1H2Ed9QTL5T1dRhBvn3lc1L4fWC Content-Type: multipart/mixed; boundary="d44b1ivlC1HxeatqxGkS12JbgLghNw6LD"; protected-headers="v1" From: Xin Li <delphij@delphij.net> To: Antoine Brodin <antoine@freebsd.org>, Xin LI <delphij@freebsd.org> Cc: d@delphij.net, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <9ef03812-a23a-8cd0-d8a1-1568c468e882@delphij.net> Subject: Re: svn commit: r312404 - head/usr.bin/sed References: <201701190801.v0J81ZG9008267@repo.freebsd.org> <CAALwa8neni57SPZAo4jW8wKu-Up0-M=weR31WtndzXdW2_jKmQ@mail.gmail.com> In-Reply-To: <CAALwa8neni57SPZAo4jW8wKu-Up0-M=weR31WtndzXdW2_jKmQ@mail.gmail.com> --d44b1ivlC1HxeatqxGkS12JbgLghNw6LD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/19/17 22:29, Antoine Brodin wrote: > On Thu, Jan 19, 2017 at 9:01 AM, Xin LI <delphij@freebsd.org> wrote: >> Author: delphij >> Date: Thu Jan 19 08:01:35 2017 >> New Revision: 312404 >> URL: https://svnweb.freebsd.org/changeset/base/312404 >> >> Log: >> Use S_ISREG instead of manual & (also it's better to compare the >> result from & and the pattern instead of just assuming it's one bit >> value). >> >> Pointed out by Tianjie Mao <tjmao tjmao com>. >> >> MFC after: 2 weeks >> Differential Revision: https://reviews.freebsd.org/D4827 >=20 > Hi, >=20 > sed -i no longer works on symlinks which breaks lots of ports. > Please revert and request an exp-run. Done. Requested as bug 216309. Cheers, --d44b1ivlC1HxeatqxGkS12JbgLghNw6LD-- --SENJsW1H2Ed9QTL5T1dRhBvn3lc1L4fWC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJYgbWIAAoJEJW2GBstM+nsil8P/2thGy73XAVRt6DFZmMMmCMy 5nRtCP9bqdBdEqVw6Xfu5/lyymhaH7oGgXiTQ8hGRKOGIvs0tGjTCr1MX23O8xkC Rp+M3JJVXNU82vidTgWeq6udiGOJ4VDTcRxvKna11LwakqDqgAVcUn3R+U7X+m/s hg2NXkEzyRWkB8qEgdTBGbW/YmHF8MFxKXuv/iV+TxlnyRFqI/JLHvSlS9MTGDri SczzIVZmkcO8vqWgPOxHB8AxYsUQu/g00BbIe7abvebYguDnnt6EUNnQJGVV9OVl jP1i8m4Yh09KxzFaJdEZL8Ld6AatBe2Gl3zRWByEKAlzFTnj0ELTD6z/gU7rmzry R38WBplt3GCHvNgjuUhZ9uiI+v7kkgchJHSHJbm9GCgpKovzm/1j41TSzHhC9p3w LXeIzIyyC0hIRJd/ThwVioIpxI44c0ZyW3xfy2x/oiMU89CZbK9272fr7rrrfFmK C4RMMu+xzNZHYgYz1UCAlmec4UOeq3IWl4/eRLabcaeKqbRbN6DaExxPLafaRxzw UNZQWxK4kigX5tNe1xzDDhHnmthFjj9AFCFtyRbJ7Yj4MB1eQurffam64yK9jJau woyBXn+CuH55ldf5o8fmOEvO0uGsWMv+TW/em9ctDD9sYIDM8pL2SlxQ+oX7v4y/ S0iYm/1+QtaJlfaXT5Mm =dTzG -----END PGP SIGNATURE----- --SENJsW1H2Ed9QTL5T1dRhBvn3lc1L4fWC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9ef03812-a23a-8cd0-d8a1-1568c468e882>