Date: Sat, 7 Nov 2015 12:13:32 -0800 From: NGie Cooper <yaneurabeya@gmail.com> To: Bruce Evans <brde@optusnet.com.au> Cc: "Conrad E. Meyer" <cem@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290505 - in head/sys: kern sys Message-ID: <F06E6DD5-E0B2-48AC-8CD9-B990FECBC487@gmail.com> In-Reply-To: <20151108054659.D5096@besplex.bde.org> References: <201511071826.tA7IQWNR035920@repo.freebsd.org> <20151108054659.D5096@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Nov 7, 2015, at 11:14, Bruce Evans <brde@optusnet.com.au> wrote: > > On Sat, 7 Nov 2015, Conrad E. Meyer wrote: > >> Log: >> Flesh out sysctl types further (follow-up of r290475) >> >> Use the right intmax_t type instead of intptr_t in a few remaining >> places. >> >> Add support for CTLFLAG_TUN for the new fixed with types. Bruce will be >> upset that the new handlers silently truncate tuned quad-sized inputs, >> but so do all of the existing handlers. > > I think I have complained about the getenv_*() integer functions before. > All of them truncate or otherwise corrupt the value. getenv_quad() > does non-blind clamping using strtoq() followed by blind scaling in > the suffix case. All others use getenv_quad() with blind truncation, > except on 64-bit arches long == quad so getenv_long() only has the same > errors as getenv_quad(). Yes. I can’t find the exact thread (it was 3-5 years ago), but I was involved and I proposed a patch which didn’t make it into the tree. Thanks, -NGie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F06E6DD5-E0B2-48AC-8CD9-B990FECBC487>