Date: Fri, 14 Apr 2017 23:55:22 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Ngie Cooper <ngie@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316953 - head/sbin/savecore Message-ID: <201704150655.v3F6tMvg010503@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201704150653.v3F6r7hJ081000@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: ngie > Date: Sat Apr 15 06:53:07 2017 > New Revision: 316953 > URL: https://svnweb.freebsd.org/changeset/base/316953 > > Log: > Switch back to non-IEC units for 1024 bytes > > I was swayed a little too quickly when I saw the wiki page discussing > kB vs KiB. Switch back as none of the code in base openly uses > IEC units via humanize_number(3) (which was my next step), and there's > a large degree of dislike with IEC vs more SI-like units. > > MFC after: 7 weeks > Submitted by: jhb, rgrimes > Sponsored by: Dell EMC Isilon > > Modified: > head/sbin/savecore/savecore.c > > Modified: head/sbin/savecore/savecore.c > ============================================================================== > --- head/sbin/savecore/savecore.c Sat Apr 15 03:28:13 2017 (r316952) > +++ head/sbin/savecore/savecore.c Sat Apr 15 06:53:07 2017 (r316953) > @@ -322,7 +322,7 @@ check_space(const char *savedir, off_t d > if (available < needed) { > syslog(LOG_WARNING, > "no dump: not enough free space on device (need at least " > - "%jdKiB for dump; %jdKiB available; %jdKiB reserved)", > + "%jdkB for dump; %jdkB available; %jdkB reserved)", > (intmax_t)needed, > (intmax_t)available + minfree, > (intmax_t)minfree); Thank you! -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704150655.v3F6tMvg010503>