Date: Wed, 11 Nov 2015 11:29:11 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Randall Stewart <rrs@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290663 - in head/sys: modules modules/tests modules/tests/callout_test modules/tests/framework tests tests/callout_test tests/framework Message-ID: <8B50A504-D6A9-49CF-917C-50F667A217A8@gmail.com> In-Reply-To: <201511101414.tAAEEfPI057133@repo.freebsd.org> References: <201511101414.tAAEEfPI057133@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Nov 10, 2015, at 06:14, Randall Stewart <rrs@FreeBSD.org> wrote: >=20 > Author: rrs > Date: Tue Nov 10 14:14:41 2015 > New Revision: 290663 > URL: https://svnweb.freebsd.org/changeset/base/290663 >=20 > Log: > Add a kernel test framework. The callout_test is a demonstration and will= only > work with the upcoming async-drain functionality. Tests can be added > to the tests directory and then the framework can be used to launch > those tests. >=20 > MFC after: 1 month > Sponsored by: Netflix Inc. > Differential Revision: https://reviews.freebsd.org/D1755 Hi Randall, This code drop is lacking a few things: 1. How can other consumers use this? 2. How does this hook in to ATF/Kyua or Jenkins? There are a bunch of style bugs in the code as well. It seems like based on the lack of documentation, this needed more revie= w/communication and probably should have been put in share/examples or tools= /test until it could be integrated into existing frameworks and used by ever= yone else. Thank you, -NGie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8B50A504-D6A9-49CF-917C-50F667A217A8>