Date: Tue, 2 Jan 2018 10:51:59 -0800 From: Yuri <yuri@rawbw.com> To: "Tobias C. Berner" <tcberner@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457914 - in head: . Mk/Uses astro/kstars audio/csound6 biology/iqtree cad/freecad cad/openscad deskutils/kdeplasma-addons editors/calligra games/xptools graphics/code-eli graphics/colm... Message-ID: <87c9a0b1-f7ab-83ef-cdb1-f5931196b6c9@rawbw.com> In-Reply-To: <201801021649.w02GnOap052049@repo.freebsd.org> References: <201801021649.w02GnOap052049@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/02/18 08:49, Tobias C. Berner wrote:
> Usage:
> USES=eigen:<version>[,<type>]
>
> version: 2 or 3 (required)
> type: build (default), run
I have 3 questions:
1. Why doesn't eigen.mk check for invalid argument values? For example,
USES=eigen:3,4,build,run doesn't cause an error as it should. I had the
same question about other USES modules, but am asking here because
eigen.mk is freshly added. It seems like checking for invalid values can
be a good idea?
2. Maybe it would be beneficial to explain in the module when particular
arguments should be used:
USES=eigen:{2,3} (defaults to build) - should be used when the port uses
Eigen headers during build, but doesn't install any headers that depend
on Eigen
USES=eigen:{2,3},run - should be used when the port doesn't use Eigen
during build, but installs headers that depend on Eigen
USES=eigen:{2,3},build,run - should be used when the port both uses
Eigen during build, and installs headers that depend on Eigen
It might not be obvious that 'run' should be used when the installed
headers use it.
3. Maybe USES=eigen:{2,3},build should conflict with NO_BUILD=yes, as
these are incompatible conditions? It seems like this could easily catch
some mistakes.
Thanks,
Yuri
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87c9a0b1-f7ab-83ef-cdb1-f5931196b6c9>