Date: Sat, 13 Aug 2011 18:43:15 -0400 From: Steve Wills <swills@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: Russell Jackson <raj@csub.edu>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils Makefile ports/sysutils/mcollective Makefile distinfo pkg-descr pkg-plist ports/sysutils/mcollective/files mcollectived.in Message-ID: <4E46FE03.8070707@FreeBSD.org> In-Reply-To: <4E46F4A7.8030300@FreeBSD.org> References: <201108131428.p7DESYAh016813@repoman.freebsd.org> <4E46F4A7.8030300@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Doug, On 08/13/11 18:03, Doug Barton wrote: > Before I forget, please don't obfuscate e-mail addresses in commit > messages. It does absolutely nothing to slow down the spammers, however > it does slow people down when they need to copy the e-mail address and > paste it into an actual e-mail. addport does this, but I'll try to catch it until it's updated. > This rc.d script has a lot of problems, and should not have been > committed as is, if for no other reason than it needs %%PREFIX%% instead > of /usr/local in command=. I've attached a patch that addresses the > following issues. It would also be helpful to visit > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html > to familiarize yourself with the basic requirements. > > 1. Add a $FreeBSD$ > 2. Unless there is a good reason, ports rc.d scripts should REQUIRE: LOGIN. This one is my fault, not the submitters. > 3. Add the comments suggested in the web page above. > 4. Move load_rc_config up to what will soon become the standard location. > 5. s#/usr/local#%%PREFIX%%# > 6. Since the -p option is almost certainly mandatory here, use > command_args instead of _flags. > > Thanks for the patch, it's committed. I'll try to review these more closely in the future. Steve -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJORv4DAAoJEPXPYrMgexuhpmkH/0ZZyk6qxPldyMzZVDXV6AVu WeLbVjzVIPEjQKO//IWjJfiQ30KdVGjaB6B5cgxZvanRcpZ3d/QH6UBz+KP2epGB K0hq8JoBmp9MbwVDyddzJldbByWK50tIvtuXbyrTeGVMmaGJX2+mGHT5N+Ss3Xqt npyG+eVHwQjCGIkwFqXHYOxU3O1FWHMu9BZOA4vN0eUZfoNX4m68W/aeknF4K2eo G093AZBFbzlm9RMLZ5JPRw3dfP6pG1QLyko7eyreFS8xEDOHzXGZalai2gi5yB9q aM/YmNg75NZTnoLofOOwhcB7zu3dkcJ9Py7ERfw+WrQlahBWDVJoJc61x89xStI= =pheZ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E46FE03.8070707>