Date: Tue, 30 Mar 2010 11:05:44 +0200 From: Dan Lukes <dan@obluda.cz> To: Rui Paulo <rpaulo@freebsd.org> Cc: freebsd-acpi@freebsd.org Subject: Re: Brightness change on notebook that follow ACPI specification (par. B.7) Message-ID: <4BB1BEE8.8070505@obluda.cz> In-Reply-To: <8D820BAA-C1B9-408C-AAF3-EA69612D2C46@freebsd.org> References: <4BB170E7.3030407@obluda.cz> <8D820BAA-C1B9-408C-AAF3-EA69612D2C46@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/30/10 10:47, Rui Paulo: >> Most notebooks have special keys (mostly Fn+something) to change brightness of LCD display. >> Some of them (my notebok, for example) follows the ACPI specification (paragraph B.7) how to announce the user request for brightness change to OS. >> I implemented such handling as part of acpi-video module. > I see nothing wrong with this patch and I think it can be committed, but I would like others to take a look. Thanks. Code review needs to be done also, but it would be nice to have more "yes, it works with my NB and OS ?.??" reports at this phase ... Did you tried it ? Which notebook and FreeBSD version ? Dan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BB1BEE8.8070505>