Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Aug 2018 10:07:09 -0700
From:      Devin Teske <dteske@freebsd.org>
To:        Brad Davis <brd@FreeBSD.org>
Cc:        Kristof Provost <kp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r337611 - head/cddl/usr.sbin/dwatch/libexec
Message-ID:  <898346B3-5E07-4045-BB93-B31DC85699DF@freebsd.org>
In-Reply-To: <1534003761.1809972.1470908040.4D49BCD1@webmail.messagingengine.com>
References:  <201808110632.w7B6WVE9009976@repo.freebsd.org> <ADEDC9DF-7A3E-40C3-A931-C87865363F39@FreeBSD.org> <1534003761.1809972.1470908040.4D49BCD1@webmail.messagingengine.com>

next in thread | previous in thread | raw e-mail | index | archive | help


> On Aug 11, 2018, at 9:09 AM, Brad Davis <brd@FreeBSD.org> wrote:
>=20
>> On Sat, Aug 11, 2018, at 7:06 AM, Kristof Provost wrote:
>> Hi Devin,
>>> On 11 Aug 2018, at 8:32, Devin Teske wrote:
>>> Author: dteske
>>> Date: Sat Aug 11 06:32:31 2018
>>> New Revision: 337611
>>> URL: https://svnweb.freebsd.org/changeset/base/337611
>>>=20
>>> Log:
>>> dwatch(1): Add systop profile
>>>=20
>>> Provides a top-like view of syscall consumers.
>>>=20
>>> MFC after:    3 days
>>> X-MFC-to:    stable/11
>>> Sponsored by:    Smule, Inc.
>>>=20
>>> Added:
>>> head/cddl/usr.sbin/dwatch/libexec/systop   (contents, props changed)
>>> Modified:
>>> head/cddl/usr.sbin/dwatch/libexec/Makefile
>>>=20
>>> Modified: head/cddl/usr.sbin/dwatch/libexec/Makefile
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
>>> --- head/cddl/usr.sbin/dwatch/libexec/Makefile    Sat Aug 11 06:13:11 20=
18    (r337610)
>>> +++ head/cddl/usr.sbin/dwatch/libexec/Makefile    Sat Aug 11 06:32:31 20=
18    (r337611)
>>> @@ -62,6 +62,7 @@ LINKS+=3D    ${LIBEXECDIR}/dwatch/sendrecv ${LIBEXECDI=
R}/dw
>>> LINKS+=3D    ${LIBEXECDIR}/dwatch/sendrecv ${LIBEXECDIR}/dwatch/send
>>> LINKS+=3D    ${LIBEXECDIR}/dwatch/sendrecv ${LIBEXECDIR}/dwatch/sendmsg
>>> LINKS+=3D    ${LIBEXECDIR}/dwatch/sendrecv ${LIBEXECDIR}/dwatch/sendto
>>> +LINKS+=3D    ${LIBEXECDIR}/dwatch/systop ${LIBEXECDIR}/dwatch/systop
>> This breaks install world:
>> install: link /usr/obj/usr/src/amd64.amd64/release/dist/base/usr/libexec/=
dwatch/systop -> /usr/obj/usr/src/amd64.amd64/release/dist/base/usr/libexec/=
dwatch/systop: No such file or directory
>=20
> Hi Devin,
>=20
> I committed a fix in r337629 to just install systop, since that seems to b=
e what you meant.. If not, please let me know and I would be happy to help c=
orrect that.
>=20
>=20

Thanks!

Silly me, the brain was not cooperating.

Modified the wrong aspect of the Makefile.
=E2=80=94=20
Devin




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?898346B3-5E07-4045-BB93-B31DC85699DF>