Skip site navigation (1)Skip section navigation (2)
Date:      26 Apr 2002 21:07:32 +1000
From:      Andrew Reilly <areilly@bigpond.net.au>
To:        Garance A Drosihn <drosih@rpi.edu>
Cc:        Mike Barcroft <mike@FreeBSD.ORG>, arch@FreeBSD.ORG, "M. Warner Losh" <imp@village.org>, freebsd-standards@FreeBSD.ORG
Subject:   Re: diff & patch problem with 'No newline'
Message-ID:  <1019819253.450.389.camel@gurney.reilly.home>
In-Reply-To: <p05111718b8ee70b3633a@[128.113.24.47]>
References:  <200202091752.g19HqFP11551@green.bikeshed.org> <p05101421b88b76a6aa12@[128.113.24.47]> <20020210040158.A26957@chiark.greenend.org.uk> <p05101422b88ba26bec5e@[128.113.24.47]> <p05111715b8ee4710a108@[128.113.24.47]> <20020425210035.A43192@espresso.q9media.com>  <p05111718b8ee70b3633a@[128.113.24.47]>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2002-04-26 at 14:12, Garance A Drosihn wrote:
> So, that's my pitch.  I feel fairly strongly that there is a
> real advantage in following the lead of Linux (+anyone using
> gnu-diff) and NetBSD in this matter.  How strongly do others
> feel that we should stick to the letter of this standard,
> because they feel the standard really has the right idea?
> 
> And if you feel that way, then could you please explain to me
> what the advantage is?  Can you come up with any tangible
> benefit of the standard which would convince a linux user to
> give up this non-standard extension which they have been
> using for at least five years?

I know that you didn't ask for it, but I'd like to voice a strong vote
of "yea" for (at least) teaching our patch to handle the "\no new line"
in diffs.  I don't any more (my MB cap has been raised), but I used to
follow the wine port by rolling my own tarballs after patching with the
incremental patches that they posted on their ftp site.  These were
_huge_ patch files, and almost always contained some "\no new line"
lines, that our patch would not DTRT with.

I don't care whether our diff produces those lines one way or the
other.  I use vi.  It doesn't believe in files without newlines at the
end.

-- 
Andrew


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1019819253.450.389.camel>