Date: Thu, 11 Apr 2024 16:53:27 -0600 From: Warner Losh <imp@bsdimp.com> To: Andrew Turner <andrew@fubar.geek.nz> Cc: Warner Losh <imp@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: ac83063d37e5 - main - bcm2838_xhci: add module Message-ID: <CANCZdfrzrYTJiCJeHGusrLQ4EwvaCxzPFb81RvEj2-j3MNZnWQ@mail.gmail.com> In-Reply-To: <ADFF4667-0A43-4C19-987C-D5998BF01B87@fubar.geek.nz> References: <202404100322.43A3MTXZ087267@gitrepo.freebsd.org> <ADFF4667-0A43-4C19-987C-D5998BF01B87@fubar.geek.nz>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Apr 11, 2024 at 4:10 AM Andrew Turner <andrew@fubar.geek.nz> wrote: > > > On 10 Apr 2024, at 04:22, Warner Losh <imp@FreeBSD.org> wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=ac83063d37e5e92ad048cc4ed958654c02103f74 > > > > commit ac83063d37e5e92ad048cc4ed958654c02103f74 > > Author: Lexi Winter <lexi@le-Fay.ORG> > > AuthorDate: 2024-04-10 03:11:36 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2024-04-10 03:11:39 +0000 > > > > bcm2838_xhci: add module > > > > bcm2838_xhci(4) is a shim for the XHCI controller on the Raspberry Pi > 4B > > SoC. It loads the controller's firmware before passing control to the > > normal xhci(4) driver. > > > > When xhci(4) is built as a module (and not in the kernel), > bcm2838_xhci > > is not built at all and the RPi4's XHCI controller won't attach due to > > missing firmware. > > > > To fix this, build a new module, bcm2838_xhci.ko, which depends on > > xhci.ko. For the dependency to work correctly, also modify xhci to > > provide the 'xhci' module in addition to the 'xhci_pci' module it > > already provided. > > > > Since bcm2838_xhci is specific to a quirk of the RPi4 SoC, only build > > the module for AArch64. > > I think this broke GENERIC-ACPI kernel. The bcm2838_xhci driver is FDT > only. > You may be right... But I don't see GENERIC-ACPI committed to the tree. Maybe you could share it with me so I can fix this? Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 11, 2024 at 4:10 AM Andrew Turner <<a href="mailto:andrew@fubar.geek.nz">andrew@fubar.geek.nz</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> > On 10 Apr 2024, at 04:22, Warner Losh <imp@FreeBSD.org> wrote:<br> > <br> > The branch main has been updated by imp:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=ac83063d37e5e92ad048cc4ed958654c02103f74" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=ac83063d37e5e92ad048cc4ed958654c02103f74</a><br>; > <br> > commit ac83063d37e5e92ad048cc4ed958654c02103f74<br> > Author: Lexi Winter <lexi@le-Fay.ORG><br> > AuthorDate: 2024-04-10 03:11:36 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2024-04-10 03:11:39 +0000<br> > <br> > bcm2838_xhci: add module<br> > <br> > bcm2838_xhci(4) is a shim for the XHCI controller on the Raspberry Pi 4B<br> > SoC. It loads the controller's firmware before passing control to the<br> > normal xhci(4) driver.<br> > <br> > When xhci(4) is built as a module (and not in the kernel), bcm2838_xhci<br> > is not built at all and the RPi4's XHCI controller won't attach due to<br> > missing firmware.<br> > <br> > To fix this, build a new module, bcm2838_xhci.ko, which depends on<br> > xhci.ko. For the dependency to work correctly, also modify xhci to<br> > provide the 'xhci' module in addition to the 'xhci_pci' module it<br> > already provided.<br> > <br> > Since bcm2838_xhci is specific to a quirk of the RPi4 SoC, only build<br> > the module for AArch64.<br> <br> I think this broke GENERIC-ACPI kernel. The bcm2838_xhci driver is FDT only.<br></blockquote><div><br></div><div>You may be right... But I don't see GENERIC-ACPI committed to the tree. Maybe you could share it with me so I can fix this?</div><div><br></div><div>Warner </div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrzrYTJiCJeHGusrLQ4EwvaCxzPFb81RvEj2-j3MNZnWQ>