Date: Thu, 15 Feb 2007 21:01:57 +0100 From: Max Laier <max@love2party.net> To: Luigi Rizzo <luigi@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/digi digi.c src/sys/kern kern_linker.c subr_firmware.c src/sys/sys linker.h Message-ID: <200702152102.06506.max@love2party.net> In-Reply-To: <200702151949.l1FJnSnp061671@repoman.freebsd.org> References: <200702151949.l1FJnSnp061671@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2390401.XFYGKt9TvH Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 15 February 2007 20:49, Luigi Rizzo wrote: > luigi 2007-02-15 19:49:27 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/dev/digi digi.c > sys/kern kern_linker.c subr_firmware.c > sys/sys linker.h > Log: > MFC kern_linker.c 1.133 and related changes: > > - push Giant into linker_reference_module(); > - introduce linker_release_module(), which also takes care of > proper locking. > > The latter also fixes a missing mtx_loc/unlock in subr_firmware.c . > > Apparently, digi.c is the only external client of > linker_reference_module() which is a bit suspicious - perhaps dev/digi/ > could make with a bit of review from someone knowledgeable to check how > the function is used, and whether it could be replaced by something > else. I have a version of digi(4) in perforce that uses firmware(9). I couldn't= =20 find testers, but with a bit of review this should be committable=20 nonetheless. =20 http://perforce.freebsd.org/depotTreeBrowser.cgi?FSPC=3D//depot/user/mlaier= /firmware/sys/dev/digi/&HIDEDEL=3DNO > Revision Changes Path > 1.58.2.3 +3 -3 src/sys/dev/digi/digi.c > 1.117.2.2 +31 -1 src/sys/kern/kern_linker.c > 1.1.2.4 +1 -3 src/sys/kern/subr_firmware.c > 1.39.2.2 +8 -0 src/sys/sys/linker.h =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2390401.XFYGKt9TvH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBF1Lw+XyyEoT62BG0RAtGXAJ9tVkvpNPtLz8n/nCvuO9BtT1bb/ACfRacf /rXXgQeKgxDQ/cWh3XhrdZU= =P+rY -----END PGP SIGNATURE----- --nextPart2390401.XFYGKt9TvH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702152102.06506.max>