Date: Tue, 11 Dec 2012 17:21:28 +0400 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308655 - in head/games/xmoto: . files Message-ID: <20121211132128.GA50148@hades.panopticon> In-Reply-To: <20121211033625.GA39028@FreeBSD.org> References: <201212110314.qBB3EErH082058@svn.freebsd.org> <20121211033625.GA39028@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Alexey Dokuchaev (danfe@FreeBSD.org) wrote: > On Tue, Dec 11, 2012 at 03:14:14AM +0000, Dmitry Marakasov wrote: > > New Revision: 308655 > > URL: http://svnweb.freebsd.org/changeset/ports/308655 > > > > +OPTIONS_DEFINE= ASIAN_TTF > > > > [...] > > > > +.if ${PORT_OPTIONS:MNLS} > > [...] > > +.if ${PORT_OPTIONS:MDOCS} > > Looks like these two should also be mentioned in OPTIONS_DEFINE. Not adding them to OPTIONS_DEFINE preserves previous behaviour and I don't think NLS and DOCS should be in the OPTIONS_DEFINE ever - they are only meaningful to be set globally, and having them in individual ports makes large builds much more painful, as a user has to set them for tons of ports (even more painful without portmaster or knowing of config-recursive). -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121211132128.GA50148>