Date: Fri, 30 Jun 2017 10:53:38 -0400 From: Steve Wills <steve@mouf.net> To: v@fatpipi.com Cc: Matthias Fechner <idefix@fechner.net>, Torsten Zuehlsdorff <tz@freebsd.org>, ruby@freebsd.org, "Vanilla I. Shu" <vanilla@freebsd.org>, Mathieu Arnold <mat@FreeBSD.org> Subject: Re: Help needed: net/rubygem-grpc Message-ID: <b46c1be2-2f56-b3b4-30ff-c9656b10303f@mouf.net> In-Reply-To: <CAB_qb68G_fv1z-KQQEPcjXGub7LF4j6QS3VFj5ydjWTdd0DPoA@mail.gmail.com> References: <4474b97e-88ec-ead8-bb13-79e5889bf237@FreeBSD.org> <b74007b8-02f7-0b58-7618-cc006074a6e1@mouf.net> <c5c542e2-c667-67b8-ec7b-6dd07069aa91@fechner.net> <bf97c60e-2076-cf5b-b587-48b978fdf51f@FreeBSD.org> <2369ae1e-30cb-52d7-6697-a99139d74479@mouf.net> <029a9c1f-de69-3bfd-ff89-1a02feb767a0@fechner.net> <412f42ff-e5e7-03e8-fcbd-10d86d0c072c@mouf.net> <CAB_qb68G_fv1z-KQQEPcjXGub7LF4j6QS3VFj5ydjWTdd0DPoA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Iagxb4ma6XhPFoS1GCqBF7WKQb0wNN0hl Content-Type: multipart/mixed; boundary="eN0MaeVQxELFcTPEgRsvijna1jrVEwNsb"; protected-headers="v1" From: Steve Wills <steve@mouf.net> To: v@fatpipi.com Cc: Matthias Fechner <idefix@fechner.net>, Torsten Zuehlsdorff <tz@freebsd.org>, ruby@freebsd.org, "Vanilla I. Shu" <vanilla@freebsd.org>, Mathieu Arnold <mat@FreeBSD.org> Message-ID: <b46c1be2-2f56-b3b4-30ff-c9656b10303f@mouf.net> Subject: Re: Help needed: net/rubygem-grpc References: <4474b97e-88ec-ead8-bb13-79e5889bf237@FreeBSD.org> <b74007b8-02f7-0b58-7618-cc006074a6e1@mouf.net> <c5c542e2-c667-67b8-ec7b-6dd07069aa91@fechner.net> <bf97c60e-2076-cf5b-b587-48b978fdf51f@FreeBSD.org> <2369ae1e-30cb-52d7-6697-a99139d74479@mouf.net> <029a9c1f-de69-3bfd-ff89-1a02feb767a0@fechner.net> <412f42ff-e5e7-03e8-fcbd-10d86d0c072c@mouf.net> <CAB_qb68G_fv1z-KQQEPcjXGub7LF4j6QS3VFj5ydjWTdd0DPoA@mail.gmail.com> In-Reply-To: <CAB_qb68G_fv1z-KQQEPcjXGub7LF4j6QS3VFj5ydjWTdd0DPoA@mail.gmail.com> --eN0MaeVQxELFcTPEgRsvijna1jrVEwNsb Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi, On 06/30/2017 06:05, Vanilla Hsu wrote: > Hi: >=20 > I update devel/grpc to 1.4.1, and change boringssl's url to official on= e. >=20 > please try it again, thanks. >=20 Thanks! We can test rubygem-grpc 1.4.1, but as long as devel/grpc is using the bundled boringssl instead of the one from the security/boringssl port, rubygem-grpc might as well use it's bundled copy of boringssl. I was really hoping to avoid that as I really think bundling libs is a bad idea in general and not something we should do. That's why I created the boringssl port. Would you mind telling me why you didn't want to take that part of the change to grpc? I don't mean to sound critical, of course. I may even decide I agree with you, but I can't until I know the reasoning. :) Also, for the record, the boringssl port has potential to cause some issues. Mathieu has agreed to look into fixing them. Copying him so he can reply if his changes to boringssl require changes to the versions of grpc and rubygem-grpc ports that link against the shared boringssl. Steve > 2017-06-30 0:11 GMT+08:00 Steve Wills <steve@mouf.net > <mailto:steve@mouf.net>>: >=20 > Hi, >=20 > On 06/28/2017 14:08, Matthias Fechner wrote: > > Thanks Steve, > > > > I already added it into our repository we work with: > > http://gitlab.toco-domains.de/FreeBSD/GitLab/commits/9.1 > <http://gitlab.toco-domains.de/FreeBSD/GitLab/commits/9.1>; > > > > I hope that is ok for you? > > My poudiere is just building and I think it will take the full ni= ght: > > https://pkg.fechner.net/index.html > <https://pkg.fechner.net/index.html>; > > > > I will try to do some tests (at least give the build a try). As I= > do not have any experience with ruby, I do not really have an idea > how to test it. > > >=20 > That's not going to work as is, see my previous message. >=20 > I have committed a port for boringssl and patched devel/grpc to use= it > and updated the rubygem-grpc patch. See attached (as always, let me= know > if it doesn't come through). >=20 > Note this will make boringssl a runtime dep of GitLab (via rubygem-= grpc > via grpc). This lets rubygem-grpc pass it's tests, except for 1, wh= ich > seems like just a test which needs updating. >=20 > If you want to run the tests, copy these files/directories: >=20 > Gemfile > Rakefile > src/proto > src/ruby/.rubocop.yml > src/ruby/.rubocop_todo.yml >=20 > from the devel/grpc WRKSRC to the corresponding location in the > rubygem-grpc WRKSRC. Then install rubygem-bundler, run "bundle inst= all" > and finally run "rake" to actually execute the tests and see result= s. > (Bundler will install a bunch of gems outside pkg, so you may want = to do > this in a throwaway jail, such as in poudriere testport -i). >=20 > Vanilla, could you commit the devel/grpc parts of the attached patc= h, or > approve me committing it? >=20 > I think it's better to create a separate port for boringssl and use= it > than to have both devel/grpc and net/rubygem-grpc bundle it. I know= > boringssl isn't meant to be used this way, based on the docs. But I= > think it's better to avoid bundling it, because bundling allows to > possibly use different versions in different ports and also means m= ore > work to update it. >=20 > Also, the github mirror used for the currently bundling of boringss= l in > devel/grpc (github.com/boringssl/boringssl > <http://github.com/boringssl/boringssl>) is an unofficial mirror th= at > seems to have died a while ago. This uses the > github.com/google/boringssl <http://github.com/google/boringssl>; > mirror which seems current and updating. So > if we are against this change to devel/grpc we should at least upda= te > the bundled version of boringssl there to the newer repo and versio= n. >=20 > Thanks, > Steve >=20 >=20 --eN0MaeVQxELFcTPEgRsvijna1jrVEwNsb-- --Iagxb4ma6XhPFoS1GCqBF7WKQb0wNN0hl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGjBAEBCgCNFiEEmPpBSlwqDvnP0K0N9c9isyB7G6EFAllWZfNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk4 RkE0MTRBNUMyQTBFRjlDRkQwQUQwREY1Q0Y2MkIzMjA3QjFCQTEPHHN0ZXZlQG1v dWYubmV0AAoJEPXPYrMgexuh8tMH/A/0Fg8a9kV+spF0sGOtTSN/xb4/WB7nOApW zPjKpS/dt8DIeDZEs1rW0WiMalQPscrwnFWyjNtsWbxiranjSUn/K4OFVRyR43ur kl8/E1LavMCben7aFEuytpZ91xajAkhzb7u/aE51WFaA4iJuSXGX1PaWlrT4sDGz umflTZp8pPuxeCcP6367IkkRvNggLeThdMpO9pDL2dmL2kNyQDkbM0M2X6PhRXhr SK/nwnAMmDph3KD4Xd/7Lvl7B53Aawnm2e4ugYH/HcYwJn7P1nOQvNbXmNsfncNK CEOOVH8AjPoC7/c4c1sp+9bytRO36byiQQ4lUNz4GoMc7Sqnom8= =TqPD -----END PGP SIGNATURE----- --Iagxb4ma6XhPFoS1GCqBF7WKQb0wNN0hl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b46c1be2-2f56-b3b4-30ff-c9656b10303f>