Date: Tue, 11 Dec 2012 14:28:41 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308655 - in head/games/xmoto: . files Message-ID: <20121211132840.GD58883@ithaqua.etoilebsd.net> In-Reply-To: <20121211132128.GA50148@hades.panopticon> References: <201212110314.qBB3EErH082058@svn.freebsd.org> <20121211033625.GA39028@FreeBSD.org> <20121211132128.GA50148@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
--sgneBHv3152wZ8jf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 11, 2012 at 05:21:28PM +0400, Dmitry Marakasov wrote: > * Alexey Dokuchaev (danfe@FreeBSD.org) wrote: > > On Tue, Dec 11, 2012 at 03:14:14AM +0000, Dmitry Marakasov wrote: > > > New Revision: 308655 > > > URL: http://svnweb.freebsd.org/changeset/ports/308655 > > >=20 > > > +OPTIONS_DEFINE=3D ASIAN_TTF > > > =20 > > > [...] > > > =20 > > > +.if ${PORT_OPTIONS:MNLS} > > > [...] > > > +.if ${PORT_OPTIONS:MDOCS} > >=20 > > Looks like these two should also be mentioned in OPTIONS_DEFINE. >=20 > Not adding them to OPTIONS_DEFINE preserves previous behaviour and I > don't think NLS and DOCS should be in the OPTIONS_DEFINE ever - they are > only meaningful to be set globally, and having them in individual ports > makes large builds much more painful, as a user has to set them for tons > of ports (even more painful without portmaster or knowing of > config-recursive). My opinion on this is if you have already an OPTIONS_DEFINE it means that t= he dialog(1) will be shown anyway so it doesn't hurt to add NLS and DOCS to it. if you do not have OPTIONS_DEFINE for something else then yes I can underst= and you don't want to bother users with dialog coming up all the time. regards, Bapt --sgneBHv3152wZ8jf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDHNQgACgkQ8kTtMUmk6EyJXgCfcf3eYON14MVlli8OwfmYUMvT yZkAn2hjNnwNmXYzfgy83/oXzjG/q05W =MH85 -----END PGP SIGNATURE----- --sgneBHv3152wZ8jf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121211132840.GD58883>