Date: Mon, 6 Mar 2017 19:35:27 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: rgrimes@freebsd.org Cc: Ngie Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r314819 - stable/11/lib/libutil Message-ID: <6096856C-D75C-4287-AD6E-2D8F9A6C7043@gmail.com> In-Reply-To: <201703070331.v273VcBc092092@pdx.rh.CN85.dnsmgr.net> References: <201703070331.v273VcBc092092@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Mar 6, 2017, at 19:31, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: … > I am less concered about fixing this and more concerned about making sure you > understood what the actual sytle.Makeilfe(9) rules are becuase it appeared > that given the counter style changes you thought there should be no white > space after VAR= in a Makefile. > > You probably understand that better than most and this is just a poor > choice of words in the commit message. I was intentionally fixing single space in leading whitespace in this commit along with unnecessary/incorrect trailing whitespace. That’s all I was trying to do, and I suppose the style.Makefile(9) portion of the commit message was overkill—technically it was fixing as little as possible so my eyes didn’t hurt whenever I opened the Makefile with vim, which also suited this requirement. So yes, "opportunistic whitespace cleaning to fix my eyes bleeding from the red colorization from my editor — vim” might have been more accurate. -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYvip/AAoJEPWDqSZpMIYVPoQP/iosb4BBWhPxIW6ygQLOYpw4 8wXjq5vCqX9WBwuF+mEvtwnO/hJ0ukWn1+P6WOJQVSXWX5ojTCXKepXVE88RnIcZ M9Ud15aqc3aDEQSYtk0wLl3jzGjccP/d+Jx/MOUp2hr86J5sDEv1+On11cvLMDAg yvww+NM4Yl/FheZgYNj4Q5tXZT+RSLhVRNQI39aQ3mPglfmr14EeOpAc1WrF3AqG gese7HQZP+orNiucFceYf/C9nDmbALJakmlVq94AKPcGqiRUxQbz2NPJ36t6nG2L 5psro7A7wwbfZUJsWhBl9cBKT7x7pv4xg8R5nWNAjWW4LQpQP1OBIQALYlmU7Mt5 yqZW+/TwQRPS1gRhrrKqmPP8QREeT6lBgRNC8i/A7lvPX9cxcW100ivyXBqh7epb QTqVlaAW+Fg4Mm12jb6ICe3xTPI+7Z1YQhaivOXzqaG8iOPnNU+EGpji8mgQXCVK 2RGYER0b1M965IVWkjkFrzQueIJvxouNivPvC9qw0yzs8KXjn4JLUGu/1YeOIuo7 HmxxuJcwXujyd57/FvPfk3+CN+49fut1PQeFMEA3PBlM7wEL0WeG5AaL2++QsICO wykA5VsguXs2vTuIuTkSoVoHua6uB6hj1aOZRR7g/ZH7hCBvyPfYfFAl9kxu2VmN Fir4VRWm1jOt91t4tV/B =KBFf -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6096856C-D75C-4287-AD6E-2D8F9A6C7043>