Date: Wed, 09 Nov 2022 22:31:41 +0100 From: Alexander Leidinger <Alexander@leidinger.net> To: Brooks Davis <brooks@freebsd.org> Cc: Mark Millard <marklmi@yahoo.com>, "Patrick M. Hausen" <pmh@hausen.com>, Warner Losh <imp@bsdimp.com>, tsoome@freebsd.org, Li-Wen Hsu <lwhsu@freebsd.org>, current@freebsd.org Subject: Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script) Message-ID: <20221109223141.Horde.nBWydmiH2iSoYq79Rb8jk38@webmail.leidinger.net> In-Reply-To: <20221109211841.GC95557@spindle.one-eyed-alien.net> References: <CANCZdfrdc%2BDbv6sDyDLcWNpXnWScEmpUsGu3q8%2BMbZRjDS8eig@mail.gmail.com> <20221108105053.Horde.eqgFiBJe2ngGAj6BkXcv5-Z@webmail.leidinger.net> <20221109134610.Horde.JB7ibQTWprHbmIUfhg7JY7f@webmail.leidinger.net> <CANCZdfptmipq%2BsS0AQ1%2B7EmLT-7YdKv8s%2BnCV7ON1Qy6-C6N9A@mail.gmail.com> <460205F9-5D59-4033-813B-C34E01BFD6C4@hausen.com> <20221109204509.Horde.lh5parVrWDSJ7kQCFa64hqe@webmail.leidinger.net> <5AFBB434-BB3B-4B5A-AB32-11DAFD03A2AD@hausen.com> <20221109205846.Horde.Rm5dcHB7p4mSbfFmxReYEDW@webmail.leidinger.net> <671B1F82-A167-45D0-8BCC-4717F433BC11@yahoo.com> <20221109211947.Horde.F4xwQw3LUvp0P2aLceiZdwf@webmail.leidinger.net> <20221109211841.GC95557@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format and has been PGP signed. --=_60q9Fa6oz_uZKdKGB16_EF6 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Quoting Brooks Davis <brooks@freebsd.org> (from Wed, 9 Nov 2022=20=20 21:18:41=20+0000): > On Wed, Nov 09, 2022 at 09:19:47PM +0100, Alexander Leidinger wrote: >> Quoting Mark Millard <marklmi@yahoo.com> (from Wed, 9 Nov 2022 >> 12:10:18 -0800): >> >> > On Nov 9, 2022, at 11:58, Alexander Leidinger >> > <Alexander@leidinger.net> wrote: >> > >> >> Quoting "Patrick M. Hausen" <pmh@hausen.com> (from Wed, 9 Nov 2022 >> >> 20:49:37 +0100): >> >> >> >>> Hi, >> >>> >> >>>> Am 09.11.2022 um 20:45 schrieb Alexander Leidinger >> >>>> <Alexander@leidinger.net>: >> >>>> But "zpool set feature@edonr=3Denabled rpool" (or any other feature >> >>>> not in the list we talk about) would render it unbootable. >> >>> >> >>> Sorry, just to be sure. So an active change of e.g. checksum or >> >>> compression algorithm >> >>> might render the system unbootable but a zpool upgrade never will? >> >>> At least not intentionally? ;-) >> >> >> >> If you mean "zpool upgrade", then no (modulo bugs). OpenZFS uses >> >> the feature flags instead of zpool upgrade. >> > >> > I'm confused by that answer: >> >> See my correction in another mail, the behavior seems to have changed >> and yes, doing a zpool upgrade on a boot pool should not be done. >> >> Maybe someone wants to check or add provisions to not do that on a >> pool which has the bootfs property set. > > Literally the entire point of the script added in the commit this thread > is about upgrade the boot pool on first boot so that seems like it would > be counterproductive. Something is missing here. Either some pointer to some safetynet for=20=20 pools=20with the bootfs property set (or a similar "this is a bootable=20= =20 pool"=20flag), or a real-world test of the script. Any brave soul around to spin up a test-VM and perform a "echo before;=20= =20 zpool=20get all rpool | grep feature; zpool upgrade rpool; echo after;=20= =20 zpool=20get all rpool | grep feature" inside? Bye, Alexander. --=20 http://www.Leidinger.net=20Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_60q9Fa6oz_uZKdKGB16_EF6 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmNsHDwACgkQEg2wmwP4 2IZZXA/+I4O5NnA4VT+pQfBy0XdY94XJz1LYZt5xnbdWbQ8GJKRQ6UIPAGyH+bL7 Lb7je3C5c1s6/S2RWmMqM6FBx/u5BpFtZsF8LwgnhgE+G3YNDtr0w9VY8fJ+Dak9 ivdzlC5G1qWCOpxOy9+5WZUmCarMrdBFLcem/V/DNbnID/WmhF312zXjCwrOk52D ZW3S4fgzXw6QMnnxFS8AkcRn+SsXZ891vxbp/fJ3AlmGlWJD/yhwITu3vlJw/R2Z nUL67qSa60DimcdJbmlJyhl9qE3mh9FbQqho2OfG8QAaoa0tLH4TtsfKXVnhVcwc Py4tLGiTJJ3josaB6zPOFqdD8FnpbJW5WFhJKbEb7r2oC4ySzB6voCQrVe+YHeM+ qndNy7NlG3oTafESrKTgYGedqpUFuZJ6mV4vHAXWT+x+n+fJwxB8370SAXKmowEU ZMjwoaHhETzh8iFHdTEeXiPW3LZrMAwueS52gLRVCHVhb+FoEAHzjIZMOPb4ky3z UGV4FUYh0zhXI8bkZE5uSKxtbGrI04noztMKXy+JaUwZ01MDr7d6tGyTMptpmcL5 msp8kbbAEPGzvcBIGvEvLnFCE+a6koL2B78CBGu0b/FnVDRgMphr62FvX0s3xUnM DPNKXkLntlGazAz8MpcEyM6lRjpAA8E6IiQzy6IgCBy/nr4Limk= =Ig1A -----END PGP SIGNATURE----- --=_60q9Fa6oz_uZKdKGB16_EF6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20221109223141.Horde.nBWydmiH2iSoYq79Rb8jk38>