Date: Fri, 5 Jul 2013 16:39:51 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Tim Kientzle <kientzle@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r252375 - head/lib/libfetch Message-ID: <838BA1C8-4950-42EE-92D5-A26A67EA7DF3@FreeBSD.org> In-Reply-To: <86hag99yc6.fsf@nine.des.no> References: <201306291551.r5TFpRc6022283@svn.freebsd.org> <86hag99yc6.fsf@nine.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 5, 2013, at 10:59, Dag-Erling Sm=F8rgrav <des@des.no> wrote: > Tim Kientzle <kientzle@FreeBSD.org> writes: >> Log: >> Fix -Wunsequenced warning. >>=20 >> Submitted by: dt71@gmx.com >=20 > Neither approved by nor even discussed with the author and maintainer. >=20 > (not saying it's wrong, but...) Actually the warning (from clang trunk) was technically wrong, as a function call is a sequence point. I reported that upstream, and it got fixed in the mean time. That said, the construction still looked a little dodgy, and if the function call ever gets changed into a macro invocation, there could be trouble. :-) -Dimitry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?838BA1C8-4950-42EE-92D5-A26A67EA7DF3>