Date: Sat, 19 Jun 2010 17:04:01 +0000 (UTC) From: Gavin Atkinson <gavin@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r209344 - head/usr.sbin/timed/timed Message-ID: <201006191704.o5JH410c041255@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: gavin Date: Sat Jun 19 17:04:01 2010 New Revision: 209344 URL: http://svn.freebsd.org/changeset/base/209344 Log: Initialise the "trials" variable to zero earlier in case we unexpectedly error out early. Found by: clang static analyzer Modified: head/usr.sbin/timed/timed/measure.c Modified: head/usr.sbin/timed/timed/measure.c ============================================================================== --- head/usr.sbin/timed/timed/measure.c Sat Jun 19 16:29:23 2010 (r209343) +++ head/usr.sbin/timed/timed/measure.c Sat Jun 19 17:04:01 2010 (r209344) @@ -86,6 +86,7 @@ measure(maxmsec, wmsec, hname, addr, pri min_idelta = min_odelta = 0x7fffffff; measure_status = HOSTDOWN; measure_delta = HOSTDOWN; + trials = 0; errno = 0; /* open raw socket used to measure time differences */ @@ -138,7 +139,6 @@ measure(maxmsec, wmsec, hname, addr, pri mstotvround(&twait, wmsec); rcvcount = 0; - trials = 0; while (rcvcount < MSGS) { (void)gettimeofday(&tcur, 0);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006191704.o5JH410c041255>