Date: Fri, 28 Aug 2015 00:48:07 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: "O'Connor, Daniel" <darius@dons.net.au> Cc: Alexey Dokuchaev <danfe@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Xin LI <delphij@freebsd.org> Subject: Re: svn commit: r287236 - head/bin/df Message-ID: <CD4128C8-BC71-4FC6-B4FD-9EFBA835AB39@gmail.com> In-Reply-To: <E8E510CD-EF49-489D-8DD2-1EFEBE0E470A@dons.net.au> References: <201508280044.t7S0ixfW038766@repo.freebsd.org> <20150828044312.GA88538@FreeBSD.org> <CAGHfRMDw0=-ze4cd7mAoHO_n%2Bt8NdYsR0On2YE5=s_gQ4=xveg@mail.gmail.com> <20150828060458.GA20642@FreeBSD.org> <E8E510CD-EF49-489D-8DD2-1EFEBE0E470A@dons.net.au>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Aug 28, 2015, at 00:24, O'Connor, Daniel <darius@dons.net.au> wrote: >=20 >> On 28 Aug 2015, at 15:34, Alexey Dokuchaev <danfe@freebsd.org> wrote: >>> On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote: >>>> On Thu, Aug 27, 2015 at 9:43 PM, Alexey Dokuchaev <danfe@freebsd.org> w= rote: >>>>> On Fri, Aug 28, 2015 at 12:44:59AM +0000, Xin LI wrote: >>>>> New Revision: 287236 >>>>> URL: https://svnweb.freebsd.org/changeset/base/287236 >>>>>=20 >>>>> Log: >>>>> Use exit() instead of return in main(). >>>>=20 >>>> Because?.. >>>=20 >>> Probably because of libxo... >>=20 >> I'm just wondering how hard is it to write sensible commit logs. :( >=20 > To put it in a hopefully more helpful way.. > Please write why your change is doing something, not what it is doing. >=20 > Saying what it is doing is OK if it's really hairy, but 99% of the time th= at isn't the case. >=20 > Assuming this is a libxo thing the commit log should have been something l= ike.. > "Use exit out of main otherwise libxo will not flush properly" > (or something similar) >=20 > Although it would be surprising if libxo required you to use exit().. Libxo (iirc) doesn't install atexit handlers, which means that you need to u= se exit (or a reason facsimile) in order for it to flush its file streams. This is unintuitive though. I wish it did the right thing as part of initial= izing the streams..=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CD4128C8-BC71-4FC6-B4FD-9EFBA835AB39>