Date: Thu, 3 Nov 2005 11:52:55 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Ceri Davies <ceri@submonkey.net>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile Message-ID: <20051103095255.GI63539@ip.net.ua> In-Reply-To: <20051103093114.GY29387@submonkey.net> References: <200511030727.jA37Rogo055689@repoman.freebsd.org> <20051103093114.GY29387@submonkey.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Nov 03, 2005 at 09:31:15AM +0000, Ceri Davies wrote:
> On Thu, Nov 03, 2005 at 07:27:50AM +0000, Ruslan Ermilov wrote:
> > ru 2005-11-03 07:27:50 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> > release Makefile
> > Log:
> > Be cross-arch friendly.
>
> > | @@ -714,7 +714,7 @@ release.8:
> > | .endif
> > | cp ${.CURDIR}/../etc/usbd.conf ${RD}/mfsfd/etc/usbd.conf
> > | cp ${.CURDIR}/../etc/master.passwd ${RD}/mfsfd/etc/master.passwd
> > | - pwd_mkdb -d ${RD}/mfsfd/etc -p ${RD}/mfsfd/etc/master.passwd
> > | + cp ${RD}/trees/base/etc/*pwd.db ${RD}/mfsfd/etc/
> > | ( for F in defaults/rc.conf netconfig protocols ; do \
> > | sed -e '/^#.*$$/d' -e 's/[:space:]*#.*$$//g' \
> > | ${RD}/trees/base/etc/$$F > ${RD}/mfsfd/stand/etc/$$F ; \
>
> I don't understand the logic. I thought that pwd_mkdb was supposed to
> *be* cross-arch friendly these days, and aren't we now just copying in
> password databases that were created with the same pwd_mkdb during "make
> distribution", so where's the win?
>
Target endianness can be different. PWD_MKDB_ENDIAN in src/etc/Makefile
handles this, but not here. We could copy the same code here with some
effort, there's just no sense in building the same files again.
Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFDad33qRfpzJluFF4RApb7AJ49cFlLAD2lieE8tBdPooKAxW8nwwCgmRwh
srtUzuJi6S5IDQw2zgQqKRw=
=89zb
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051103095255.GI63539>