Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Jan 2008 06:27:48 +0200
From:      Giorgos Keramidas <keramida@freebsd.org>
To:        Andre Oppermann <andre@freebsd.org>
Cc:        James Healy <jhealy@swin.edu.au>, Lawrence Stewart <lastewart@swin.edu.au>, net@freebsd.org, Robert Watson <rwatson@freebsd.org>, arch@freebsd.org
Subject:   Re: Coordinating TCP projects
Message-ID:  <20080117042747.GA1617@kobe.laptop>
In-Reply-To: <4786D23A.1080509@freebsd.org>
References:  <20071219123305.Y95322@fledge.watson.org> <47693DBD.6050104@swin.edu.au> <476A45D6.6030305@freebsd.org> <47858D35.6060006@swin.edu.au> <4786D23A.1080509@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2008-01-11 03:19, Andre Oppermann <andre@freebsd.org> wrote:
>Lawrence Stewart wrote:
>>> I've got a rewritten and much more efficient tcp_reass() function in
>>> my local tree.  I'll import it into Perforce next week with all the
>>> other stuff.  You may want to base your auto-sizing work on it.  The
>>> only missing parts are some statistics gathering.
>>
>> Where abouts is this code? A cursory browse through the Perforce web
>> front-end reveals nothing. We're going to start work on the TCP
>> reassembly queue autotuning patch now and if you think we should base
>> it on your new tcp_reass() we need to have a look at it.
>
> The first cut is now at //depot/projects/tcp_reass/ however I made a
> mistake when creating the branch and now the code is in the same
> changeset as the branching itself.  Doesn't make it easy to do a diff.
> Have to see how I can fix that.  Anyway, have a look and I'm going to
> finish/fix the code tomorrow evening.

Hi Andre,

You can `p4 obliterate' the branch and recommit.

Alternatively, you can commit a second change, with the clean
branch-origin source, and then re-commit the tcp_reass code.

The perforce-admins may have a preferred way of fixing this, so it's
probably worth asking too.

HTH,
Giorgos



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080117042747.GA1617>