Date: Tue, 31 Mar 2015 21:07:22 +0000 From: "dim (Dimitry Andric)" <phabric-noreply@FreeBSD.org> To: freebsd-toolchain@freebsd.org Subject: [Differential] [Commented On] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage Message-ID: <9dad4bfd380916be7ee8cf6166c533e5@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-k4xxaczek6fqqbquc4di-req@FreeBSD.org> References: <differential-rev-PHID-DREV-k4xxaczek6fqqbquc4di-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
dim added inline comments.
INLINE COMMENTS
Makefile.inc1:416 These are also unconditionally used in the previous block for WMAKENV, e.g.:
```
WMAKEENV+= CC="${XCC} ${XCFLAGS}" CXX="${XCXX} ${XCFLAGS} ${XCXXFLAGS}" \
DEPFLAGS="${DEPFLAGS}" \
CPP="${XCPP} ${XCFLAGS}" \
AS="${XAS}" AR="${XAR}" LD="${XLD}" NM=${XNM} \
OBJDUMP=${XOBJDUMP} OBJCOPY="${XOBJCOPY}" \
RANLIB=${XRANLIB} STRINGS=${XSTRINGS} \
SIZE="${XSIZE}"
```
and just before that, they are unconditionally defined:
```
XCOMPILERS= CC CXX CPP
.for COMPILER in ${XCOMPILERS}
.if defined(CROSS_COMPILER_PREFIX)
X${COMPILER}?= ${CROSS_COMPILER_PREFIX}${${COMPILER}}
.else
X${COMPILER}?= ${${COMPILER}}
.endif
.endfor
XBINUTILS= AS AR LD NM OBJCOPY OBJDUMP RANLIB SIZE STRINGS
.for BINUTIL in ${XBINUTILS}
.if defined(CROSS_BINUTILS_PREFIX)
X${BINUTIL}?= ${CROSS_BINUTILS_PREFIX}${${BINUTIL}}
.else
X${BINUTIL}?= ${${BINUTIL}}
.endif
.endfor
```
So I think it is unnecessary to check them again.
REVISION DETAIL
https://reviews.freebsd.org/D2187
To: dim, imp, bapt, rodrigc
Cc: imp, freebsd-toolchain
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9dad4bfd380916be7ee8cf6166c533e5>