Date: Wed, 1 Mar 2023 22:42:49 -0600 From: Kyle Evans <kevans@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Kyle Evans <kevans@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6b4ef4b16a69 - main - daemon: use braces with 'if' consistently Message-ID: <CACNAnaFs5z9Vgre34bjSO4kSG_frv7sUO%2BgNfesPo=qGEy2ZFQ@mail.gmail.com> In-Reply-To: <ZAAl1xad3s/Wqk22@FreeBSD.org> References: <202303020300.32230wHb032429@gitrepo.freebsd.org> <ZAAl1xad3s/Wqk22@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 1, 2023 at 10:28=E2=80=AFPM Alexey Dokuchaev <danfe@freebsd.org=
> wrote:
>
> On Thu, Mar 02, 2023 at 03:00:58AM +0000, Kyle Evans wrote:
> > commit 6b4ef4b16a6930d91d0d99c4ceb75cd43a7526c1
> >
> > daemon: use braces with 'if' consistently
> > [...]
> > ...
> > diff --git a/usr.sbin/daemon/daemon.c b/usr.sbin/daemon/daemon.c
> > index edcdf3141fcc..f9c1f73e193c 100644
> > --- a/usr.sbin/daemon/daemon.c
> > +++ b/usr.sbin/daemon/daemon.c
> > @@ -173,14 +173,16 @@ main(int argc, char *argv[])
> > break;
> > case 'l':
> > logfac =3D get_log_mapping(optarg, facilitynames)=
;
> > - if (logfac =3D=3D -1)
> > + if (logfac =3D=3D -1) {
> > errx(5, "unrecognized syslog facility");
> > + }
>
> Not only that I don't quite understand how does this commit really
> improve anything, but looks like it's badly formatted as well.
>
A-ha, thought I had caught all of the style issues but it appears not.
Thanks,
Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFs5z9Vgre34bjSO4kSG_frv7sUO%2BgNfesPo=qGEy2ZFQ>