Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Nov 2008 01:08:01 +0800
From:      Ganbold <ganbold@micom.mng.net>
To:        Rui Paulo <rpaulo@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r185433 - head/sys/dev/asmc
Message-ID:  <493176F1.5070805@micom.mng.net>
In-Reply-To: <200811291420.mATEKa6t053437@svn.freebsd.org>
References:  <200811291420.mATEKa6t053437@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Rui Paulo wrote:
> Author: rpaulo
> Date: Sat Nov 29 14:20:36 2008
> New Revision: 185433
> URL: http://svn.freebsd.org/changeset/base/185433
>
> Log:
>   Check for non-existing model DMI string.
>   
>   Submitted by:	ganbold
>   Found with:	Coverity Prevent(tm)
>   CID:         	2434
>   MFC after:	1 week
>
> Modified:
>   head/sys/dev/asmc/asmc.c
>
> Modified: head/sys/dev/asmc/asmc.c
> ==============================================================================
> --- head/sys/dev/asmc/asmc.c	Sat Nov 29 13:34:59 2008	(r185432)
> +++ head/sys/dev/asmc/asmc.c	Sat Nov 29 14:20:36 2008	(r185433)
> @@ -254,6 +254,9 @@ asmc_match(device_t dev)
>  	char *model;
>  
>  	model = getenv("smbios.system.product");
> +	if (model == NULL)
> +		return (NULL);
> +
>  	for (i = 0; asmc_models[i].smc_model; i++) {
>  		if (!strncmp(model, asmc_models[i].smc_model, strlen(model))) {
>  			freeenv(model);
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
>
>
>
>   
Thank you.

Ganbold

-- 
When a girl can read the handwriting on the wall, she may be in the
wrong rest room.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?493176F1.5070805>