Date: Fri, 21 Apr 2017 19:33:38 -0700 From: Rui Paulo <rpaulo@me.com> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r317277 - head/sys/crypto/chacha20 Message-ID: <AFC8F371-13A1-4075-BF7C-B1E1D9B04A94@me.com> In-Reply-To: <201704220106.v3M16NLH097822@repo.freebsd.org> References: <201704220106.v3M16NLH097822@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 21, 2017, at 18:06, Dag-Erling Sm=C3=B8rgrav <des@freebsd.org> = wrote: >=20 > Author: des > Date: Sat Apr 22 01:06:23 2017 > New Revision: 317277 > URL: https://svnweb.freebsd.org/changeset/base/317277 >=20 > Log: > Fix counter increment in Salsa and ChaCha. >=20 > In my eagerness to eliminate a branch which is taken once per 2^38 > bytes of keystream, I forgot that the state words are in host order. > Thus, the counter increment code worked fine on little-endian > machines, but not on big-endian ones. Switch to a simpler = (branchful) > solution. I=E2=80=99m surprised there=E2=80=99s no mention of who reviewed your = change, especially when you=E2=80=99re changing crypto code.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AFC8F371-13A1-4075-BF7C-B1E1D9B04A94>