Date: Thu, 25 Aug 2016 18:17:45 +0200 From: Guido Falsi <madpilot@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, Ed Schouten <ed@nuxi.nl> Cc: svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org> Subject: Re: svn commit: r303988 - head/lib/libc/gen Message-ID: <9303f35a-7941-3d14-4068-563d6af5b7ee@FreeBSD.org> In-Reply-To: <f4d148a5-2746-b88a-dd84-28c88de91bde@FreeBSD.org> References: <201608120703.u7C73whf007189@repo.freebsd.org> <d23b295a-1902-193c-dee6-ba49ebd77280@FreeBSD.org> <9ae1c2eb-02ad-b8fe-6aff-7e17e955607a@FreeBSD.org> <CABh_MKkxD3OTF7VO9Rq_eZyqHPN%2BxVws3q3dsH2R3DfZ343kFw@mail.gmail.com> <2632f5f8-d765-3df7-74d7-da878eb4b7a8@FreeBSD.org> <CABh_MKm_YQ3bJD19Cz1vBCGr=YxuzctXV6F1iqMASkSx-PsVMw@mail.gmail.com> <2e308383-bfbb-cccd-cfc2-eba63d275f5e@FreeBSD.org> <f4d148a5-2746-b88a-dd84-28c88de91bde@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7MTtqeufihi9d5eSlm4o2DWArJ9KS1R0l Content-Type: multipart/mixed; boundary="P31vmXg7LNa0SeIeKNV3aBQmt8toJtijF" From: Guido Falsi <madpilot@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, Ed Schouten <ed@nuxi.nl> Cc: svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org> Message-ID: <9303f35a-7941-3d14-4068-563d6af5b7ee@FreeBSD.org> Subject: Re: svn commit: r303988 - head/lib/libc/gen References: <201608120703.u7C73whf007189@repo.freebsd.org> <d23b295a-1902-193c-dee6-ba49ebd77280@FreeBSD.org> <9ae1c2eb-02ad-b8fe-6aff-7e17e955607a@FreeBSD.org> <CABh_MKkxD3OTF7VO9Rq_eZyqHPN+xVws3q3dsH2R3DfZ343kFw@mail.gmail.com> <2632f5f8-d765-3df7-74d7-da878eb4b7a8@FreeBSD.org> <CABh_MKm_YQ3bJD19Cz1vBCGr=YxuzctXV6F1iqMASkSx-PsVMw@mail.gmail.com> <2e308383-bfbb-cccd-cfc2-eba63d275f5e@FreeBSD.org> <f4d148a5-2746-b88a-dd84-28c88de91bde@FreeBSD.org> In-Reply-To: <f4d148a5-2746-b88a-dd84-28c88de91bde@FreeBSD.org> --P31vmXg7LNa0SeIeKNV3aBQmt8toJtijF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/25/16 18:05, Bryan Drewery wrote: > On 8/25/16 1:27 AM, Guido Falsi wrote: >> On 08/24/16 21:49, Ed Schouten wrote: >>> 2016-08-24 20:30 GMT+02:00 Bryan Drewery <bdrewery@freebsd.org>: >>>> That would only fix stable/11, stable/10, stable/9, releng/11.0. >>>> >>>> It won't fix releng/10.3, releng/10.2, releng/10.1, releng/9.3, etc.= =2E. >>>> without an EN. >>>> >>>> It won't fix stable/11 - 1, stable/10 - 1, etc. >>>> >>>> It will never fix releng/8.4 (unsupported releases) since so@ won't = EN >>>> to those. People do sometimes need to build these older releases st= ill. >>>> >>>> It creates a line in the sand where we can never build checkouts old= er >>>> than where the fix was at. So I don't think it is the appropriate f= ix. >>> >>> Good point! >>> >>> Just for the record: Bryan and I just discussed this matter in more >>> detail on IRC. We came up with a workaround that should be pretty >>> good. >>> >>> Attached is a patch for <libgen.h> that adds some extra logic, so tha= t >>> any calls to basename() and dirname() will expand to calls to >>> __old_basename() and __old_dirname(). Using __sym_compat(), these wil= l >>> cause the compiler to generate calls to basename@FBSD_1.0 and >>> dirname@FBSD_1.0. >>> >>> According to Bryan, this fixes the problems he was experiencing. >>> >> >> I just tried using the attached patch to build a nanobsd image, host i= s >> amd64 head at r304773 with this patch applied, target is i386 >> releng/11.0 at r304729. >> >=20 > What did you apply the patch to? >=20 > You need to apply to the source tree, then do a buildworld/installworld= > for the host, then try nanobsd. I did apply it to the source tree of the host machine, and did not apply it to the nanobsd sources. The error message is very different from the previous one and involves symbol versioning. >=20 >> I've got it failing early during build: >> >> --- _bootstrap-tools-usr.bin/xinstall --- >> xinstall.o: In function `install': >> /usr/local/nanobsd/rr-trunk/src/usr.bin/xinstall/xinstall.c:(.text+0xf= 55): >> undefined reference to `basename@FBSD_1.0' >> cc: error: linker command failed with exit code 1 (use -v to see invoc= ation) >> *** [xinstall] Error code 1 >> >> make[3]: stopped in /usr/local/nanobsd/rr-trunk/src/usr.bin/xinstall >> 1 error >> >> make[3]: stopped in /usr/local/nanobsd/rr-trunk/src/usr.bin/xinstall >> *** [_bootstrap-tools-usr.bin/xinstall] Error code 2 >> >> Did I miss some needed procedure? >> >> Thanks! >> >=20 >=20 --=20 Guido Falsi <madpilot@FreeBSD.org> --P31vmXg7LNa0SeIeKNV3aBQmt8toJtijF-- --7MTtqeufihi9d5eSlm4o2DWArJ9KS1R0l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEyBAEBCAAcBQJXvxpGFRxtYWRwaWxvdEBmcmVlYnNkLm9yZwAKCRAa5oYOVsvS k3sbCADi8EBsyq1Bt3ynrAWtmDUB2Y/yHTEJx7/qN5KatQOU/EIUZFCGV4VLNS10 IACRvk6+t2nTfKb412u5jzzAmBTjLcu/ZiEkUdC+5gy9llvFInb9yvpsrL5QKzKC gZ1wzsgh/f7XudSbeYl02uQnjGexEM3MbRD5HLyzTvbjcRljFHXRPq9aE6lOBy2E pd6f66umFnsTjt7ycd4mLCAouuldVyC7Mh9Ibuwsl8NoVRleth3FBCRH7tVyr+v6 WNtClj4ivw9Y8t+1SfYoCywArrtnUB46M0tR19cQIhu+qoJknGPoN3yvhhnW41VG yGG3i/dA4euH8yeJ/oYRNRswQMP4 =vp1C -----END PGP SIGNATURE----- --7MTtqeufihi9d5eSlm4o2DWArJ9KS1R0l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9303f35a-7941-3d14-4068-563d6af5b7ee>