Date: Wed, 14 Jul 2004 10:43:23 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: Alfred Perlstein <alfred@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_event.c src/sys/sys eventvar.h Message-ID: <Pine.NEB.3.96L.1040714103934.83353K-100000@fledge.watson.org> In-Reply-To: <200407140702.i6E724mV093920@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 14 Jul 2004, Alfred Perlstein wrote: > Log: > Make FIOASYNC, FIOSETOWN and FIOGETOWN work on kqueues. Have you tried testing this on a kqueue used to monitor signals? I'd draw your particular attention to the following newly enabled code path: pgsigio() -> psignal() -> tdsignal() -> do_tdsignal() -> KNOTE() -> knote() -> KNOTE_ACTIVATE() -> knote_enqueue() -> kqueue_wakeup() -> pgsigio() It strikes me that adding sigio support to kqueue opens a massive can of worms, not least of which is how you prevent the above from causing the system to panic, not to mention how you handle locking in what is otherwise a set of leaf functions in kqueue. I'd like it if you could back this out until locking for kqueue is resolved, as while this is no doubt a useful feature, having the locking working is much more useful to us for 5.3. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1040714103934.83353K-100000>