Date: Thu, 9 Aug 2012 10:12:44 -0600 From: Warner Losh <imp@bsdimp.com> To: Dan McGregor <danismostlikely@gmail.com> Cc: freebsd-hackers@freebsd.org Subject: Re: Consistent use of lex flags Message-ID: <538F7D01-690B-46A3-982D-F2BF9EFE8621@bsdimp.com> In-Reply-To: <CACS%2B7ZSu5FuBfXDvJXXYX%2B_ugmYGDfvut9PrdmRX4zkxLmxnvg@mail.gmail.com> References: <CACS%2B7ZSu5FuBfXDvJXXYX%2B_ugmYGDfvut9PrdmRX4zkxLmxnvg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
All these changes look good. Since they aren't changes to lex itself, but how the base uses standard lex interfaces, I'd say we should just commit it. Warner On Aug 8, 2012, at 2:59 PM, Dan McGregor wrote: > Hi. > > I was just noticing that mkcsmapper doesn't build with clang. I saw two > ways to do this, the first being to #define YY_NO_INPUT, and the other to > use the %option noinput lex flag. > > While there, I decided to explore and I changed a bunch of #defines to the > standard lex way of doing things. I thought it would be good if all the > code that originated in FreeBSD could be consistent. > > Thoughts? > <lex.diff>_______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?538F7D01-690B-46A3-982D-F2BF9EFE8621>