Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 20 May 2012 13:08:15 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Andriy Gapon <avg@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r235478 - head/cddl/contrib/opensolaris/cmd/zpool
Message-ID:  <20120520110815.GB1442@garage.freebsd.pl>
In-Reply-To: <201205151707.q4FH7UDU096834@svn.freebsd.org>
References:  <201205151707.q4FH7UDU096834@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--H1spWtNR+x+ondvy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 15, 2012 at 05:07:30PM +0000, Andriy Gapon wrote:
> Author: avg
> Date: Tue May 15 17:07:29 2012
> New Revision: 235478
> URL: http://svn.freebsd.org/changeset/base/235478
>=20
> Log:
>   zpool_do_import: use /dev instead of /dev/dsk as a default
>  =20
>   This affects behavior of zpool import without -d option.

How does it affect 'zpool import' behaviour? On FreeBSD when -d is not
given we should not scan entire /dev/, but take all available GEOM
providers from the GEOM.

>   Reported by:	Bruce Cran <bruce@cran.org.uk>
>   Submitted by:	Fabian Keil <freebsd-listen@fabiankeil.de>
>   MFC after:	2 weeks
>=20
> Modified:
>   head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c
>=20
> Modified: head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c	Tue May 15 16:17=
:30 2012	(r235477)
> +++ head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c	Tue May 15 17:07=
:29 2012	(r235478)
> @@ -1909,7 +1909,7 @@ zpool_do_import(int argc, char **argv)
> =20
>  	if (searchdirs =3D=3D NULL) {
>  		searchdirs =3D safe_malloc(sizeof (char *));
> -		searchdirs[0] =3D "/dev/dsk";
> +		searchdirs[0] =3D "/dev";
>  		nsearch =3D 1;
>  	}
> =20

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--H1spWtNR+x+ondvy
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAk+40J8ACgkQForvXbEpPzSXTACcC0daM1NfstkhhgBZ/vgysnCR
msIAnRvbehJca4LAwyzQ7b3Zh+K1xdZZ
=4l9w
-----END PGP SIGNATURE-----

--H1spWtNR+x+ondvy--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120520110815.GB1442>